Cleaned up code

Author: rimi-itk

.github/workflows/pr.yml

@@ -23,8 +23,8 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php-versions: [ '8.3' ]
-        dependency-version: [ prefer-lowest, prefer-stable ]
+        php-versions: ["8.3"]
+        dependency-version: [prefer-lowest, prefer-stable]
     steps:
       - uses: actions/checkout@master
       - name: Setup PHP, with composer and extensions
@@ -58,7 +58,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php-versions: [ '8.3' ]
+        php-versions: ["8.3"]
     steps:
       - uses: actions/checkout@master
       - name: Setup PHP, with composer and extensions
@@ -90,7 +90,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        php-versions: [ '8.3' ]
+        php-versions: ["8.3"]
     steps:
       - uses: actions/checkout@master
       - name: Setup PHP, with composer and extensions

composer.json

@@ -14,7 +14,7 @@
         "dealerdirect/phpcodesniffer-composer-installer": "^1.0",
         "drupal/coder": "^8.3",
         "drupal/maillog": "^1.1",
-        "ergebnis/composer-normalize": "^2.42",
+        "ergebnis/composer-normalize": "^2.47",
         "mglaman/phpstan-drupal": "^1.2",
         "phpstan/extension-installer": "^1.3",
         "phpstan/phpstan-deprecation-rules": "^1.1"

config_helper.info.yml

@@ -1,9 +1,8 @@
-name: 'config_helper'
+name: "config_helper"
 type: module
-description: 'Config helper'
+description: "Config helper"
 # Used only for development and testing.
 hidden: true
 core_version_requirement: ^10
-package: 'ITK'
-
+package: "ITK"
 # https://www.drupal.org/node/2087879

config_helper.services.yml

@@ -1,6 +1,6 @@
 services:
   Drupal\config_helper\ConfigHelper:
     arguments:
-      - '@module_handler'
-      - '@config.factory'
-      - '@file_system'
+      - "@module_handler"
+      - "@config.factory"
+      - "@file_system"

docker-compose.yml

@@ -2,7 +2,7 @@
 
 services:
   phpfpm:
-    image: itkdev/php8.4-fpm:latest
+    image: itkdev/php8.3-fpm:latest
     user: ${COMPOSE_USER:-deploy}
     volumes:
       - .:/app

src/ConfigHelper.php

@@ -32,7 +32,7 @@ public function __construct(
    */
   public function addEnforcedDependency(
     string $module,
-    array $configNames
+    array $configNames,
   ): void {
     foreach ($configNames as $name) {
       $this->logger->info(sprintf('Config name: %s', $name));
@@ -54,7 +54,7 @@ public function addEnforcedDependency(
    */
   public function removeEnforcedDependency(
     string $module,
-    array $configNames
+    array $configNames,
   ): void {
     foreach ($configNames as $name) {
       $this->logger->info(sprintf('Config name: %s', $name));
@@ -86,7 +86,7 @@ public function removeEnforcedDependency(
   public function writeModuleConfig(
     string $module,
     mixed $optional,
-    array $configNames
+    array $configNames,
   ): void {
     $moduleConfigPath = $this->getModuleConfigPath($module, $optional);
     if (!is_dir($moduleConfigPath)) {
@@ -113,28 +113,28 @@ public function renameConfig(
     string $from,
     string $to,
     array $configNames,
-    bool $regex = FALSE
+    bool $regex = FALSE,
   ): void {
     $replacer = $regex
       ? static fn (string $subject) => preg_replace($from, $to, $subject)
       : static fn (string $subject) => str_replace($from, $to, $subject);
 
-      foreach ($configNames as $name) {
-        $config = $this->configFactory->getEditable($name);
-        $data = $config->getRawData();
-        $newData = $this->replaceKeysAndValues($replacer, $data);
-        if ($newData !== $data) {
-          $config->setData($newData);
-          $this->logger->info(sprintf('Saving updated config %s', $name));
-          $config->save();
-        }
+    foreach ($configNames as $name) {
+      $config = $this->configFactory->getEditable($name);
+      $data = $config->getRawData();
+      $newData = $this->replaceKeysAndValues($replacer, $data);
+      if ($newData !== $data) {
+        $config->setData($newData);
+        $this->logger->info(sprintf('Saving updated config %s', $name));
+        $config->save();
+      }
 
-        $newName = $replacer($name);
-        if ($newName !== $name) {
-          $this->logger->info(sprintf('Renaming config %s to %s', $name, $newName));
-          $this->configFactory->rename($name, $newName);
-        }
+      $newName = $replacer($name);
+      if ($newName !== $name) {
+        $this->logger->info(sprintf('Renaming config %s to %s', $name, $newName));
+        $this->configFactory->rename($name, $newName);
       }
+    }
   }
 
   /**
@@ -218,7 +218,7 @@ public function getModuleConfigPath(string $module, bool $optional): string {
    */
   private function replaceKeysAndValues(
     callable $replacer,
-    array $input
+    array $input,
   ): array {
     $return = [];
     foreach ($input as $key => $value) {

src/Drush/Commands/ConfigHelperCommands.php

@@ -89,7 +89,7 @@ public function writeModuleConfig(
     array $options = [
       'optional' => FALSE,
       'enforced' => FALSE,
-    ]
+    ],
   ): void {
     $this->initialize();
 
@@ -129,7 +129,7 @@ public function rename(
     array $configNames,
     array $options = [
       'regex' => FALSE,
-    ]
+    ],
   ): void {
     $this->initialize();