Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILD : rz-type module build fails in RizinBundled build step #3351

Closed
1 of 3 tasks
brightprogrammer opened this issue Jun 4, 2024 · 3 comments
Closed
1 of 3 tasks
Labels
rizin Needs changes into rizin codebase.
Milestone

Comments

@brightprogrammer
Copy link

brightprogrammer commented Jun 4, 2024

Environment information

  • Operating System: Endeavour OS
  • Cutter version: cutter 2.4.0-dev-38c683b
  • Obtained from:
    • Built from source
    • Downloaded release from Cutter website or GitHub
    • Distribution repository
  • File format: None

Describe the bug
When building cutter from source, build fails in (Rizin Bundled) rz-type module build. Build log for rz-type module build can be found in this paste.

To Reproduce

Steps to reproduce the behavior:

git clone --recurse-submodules [email protected]:rizinorg/cutter.git && cd cutter && cmake -B build && cmake --build build

Expected behavior

Build should work without any errors.

Possible Fix
The problem is fixed when I add tree-sitter as dependency to rz-type module. Currently rz-type only has tree-sitter-c as it's dependency.

tree_sitter_c_dep = dependency('tree-sitter-c')

rz_type_inc = [
  platform_inc,
  'parser',
]

rz_type = library('rz_type', rz_type_sources,
  include_directories: rz_type_inc,
  dependencies: [
    rz_util_dep,
    tree_sitter_c_dep,
    lrt,
+    dependency('tree-sitter')
  ],
  install: true,
  implicit_include_directories: false,
  install_rpath: rpath_lib,
  soversion: rizin_libversion,
  version: rizin_version,
  name_suffix: lib_name_suffix,
  name_prefix: lib_name_prefix,
)
@notxvilka
Copy link

@brightprogrammer I think it was fixed, right?

@brightprogrammer
Copy link
Author

It was then, I never faced this issue again

@karliss
Copy link
Member

karliss commented Mar 14, 2025

If the problem is resolved, I am going to close this.

@karliss karliss closed this as completed Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rizin Needs changes into rizin codebase.
Projects
None yet
Development

No branches or pull requests

4 participants