Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failure against PySide >= 6.8 #3384

Open
1 of 3 tasks
misaka18931 opened this issue Oct 17, 2024 · 0 comments
Open
1 of 3 tasks

Build failure against PySide >= 6.8 #3384

misaka18931 opened this issue Oct 17, 2024 · 0 comments
Labels
Python Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit.

Comments

@misaka18931
Copy link

misaka18931 commented Oct 17, 2024

Environment information

  • Operating System: NixOS
  • Cutter version:
  • Obtained from:
    • Built from source
    • Downloaded release from Cutter website or GitHub
    • Distribution repository
  • File format:

Describe the bug

PySide::SignalManager::instance() was removed here in this commit, before the release of 6.8.0.

This change in pyside caused a compilation error on cutter/src/common/PythonManager.cpp:136:28 which called PySide::SignalManager::instance().clear();:

/build/source/src/common/PythonManager.cpp:136:28: error: 'instance' is not a member of 'PySide::SignalManager'
  136 |     PySide::SignalManager::instance().clear();

Inferring from code in that same commit, it seems that this line is no longer needed.
But I'm not sure as I'm not familiar with Qt.

To Reproduce

Build cutter against Qt & PySide >= 6.8

Expected behavior

No build failure.

Additional context

The full compilation log can be viewed on the build server of NixOS. link

@karliss karliss added Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit. Python labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Python Qt Issues and pull-requests regarding or caused-by the underlying Qt toolkit.
Projects
None yet
Development

No branches or pull requests

2 participants