Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update definition of power entering and leaving the battery, update use of efficiency #203

Open
jakobgemassmer opened this issue Nov 7, 2023 · 1 comment
Assignees
Labels
high prio Very important invalid This doesn't seem right question Further information is requested

Comments

@jakobgemassmer
Copy link
Collaborator

Implement a new definition of how to deal with efficiency:

  • If we specify a charging curve (e.g. constant 100 kW), then this 100 kW comes from the grid. In other words, less power arrives in the (vehicle) battery due to the efficiency.
  • When discharging a (vehicle) battery with 100 kW, 100 kW goes into the grid or wherever it goes. Meaning more power is taken from the (vehicle) battery due to its efficiency.

The (dis)charging curve therefore defines P_in and P_out in this picture:
image
More info: https://smooth.readthedocs.io/en/latest/smooth.components.html#module-smooth.components.component_battery

Additionally: Ensure that the efficiency is considered in all strategies and for vehicles and stationary batteries!
Example: In peak_load_window the stat. battery does not consider the efficiency when discharging.

@jakobgemassmer jakobgemassmer added invalid This doesn't seem right high prio Very important labels Nov 7, 2023
@stefansc1 stefansc1 added the question Further information is requested label Nov 22, 2023
@stefansc1
Copy link
Collaborator

This is already the behavior when using target_power of the battery load/unload functions. See test_components for example, test_charging and test_unload in particular. Do you have an example file where the efficiency is not accounted for, in your opinion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high prio Very important invalid This doesn't seem right question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants