Fix min_frames_per_camera bug in multi-camera frame selection

- Fixed duplicate frame detection by tracking frame names instead of tuples
- Ensured camera_frame_counts is updated in second pass
- Properly enforces minimum frames per camera requirement

Author: rmaher001

custom_components/llmvision/media_handlers.py

@@ -176,6 +176,7 @@ def _select_frames_with_minimums(self, camera_frames, max_frames, min_frames_per
         all_frames.sort(key=lambda x: x[2])
 
         selected_frames = []
+        selected_frame_names = set()  # Track selected frames by name
         camera_frame_counts = {camera: 0 for camera in camera_frames.keys()}
 
         # First pass: try to satisfy minimum frames per camera
@@ -185,6 +186,7 @@ def _select_frames_with_minimums(self, camera_frames, max_frames, min_frames_per
 
             if camera_frame_counts[camera_entity] < min_frames_per_camera:
                 selected_frames.append((frame_name, frame_data, ssim_score))
+                selected_frame_names.add(frame_name)
                 camera_frame_counts[camera_entity] += 1
 
         # Second pass: fill remaining slots with best frames
@@ -193,10 +195,12 @@ def _select_frames_with_minimums(self, camera_frames, max_frames, min_frames_per
                 break
 
             # Skip if already selected
-            if (frame_name, frame_data, ssim_score) in selected_frames:
+            if frame_name in selected_frame_names:
                 continue
 
             selected_frames.append((frame_name, frame_data, ssim_score))
+            selected_frame_names.add(frame_name)
+            camera_frame_counts[camera_entity] += 1
 
         return selected_frames, camera_frame_counts
 

tests/integration/test_structured_output_integration.py

@@ -597,7 +597,7 @@ async def test_localai_structured_output(self):
             CONF_IP_ADDRESS: localai_host,
             CONF_PORT: localai_port,
             CONF_HTTPS: False,
-            CONF_DEFAULT_MODEL: "opengvlab_internvl3_5-8b"
+            CONF_DEFAULT_MODEL: "llava-1.5"
         }
 
         # Monkey patch to use real session