Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max_snr weight adjustment. #137

Open
rmjarvis opened this issue Jun 23, 2022 · 0 comments
Open

Fix max_snr weight adjustment. #137

rmjarvis opened this issue Jun 23, 2022 · 0 comments

Comments

@rmjarvis
Copy link
Owner

In the Y6 testing, we discovered (due to a different bug that was fixed in #136) that the weight adjustment we do to bring nominal S/N values down to the requested max_snr value is adding a bit too much noise. If calculateSNR is rerun after this step, the measured SNR is often about 10% lower. Around 90 when the requested max_snr=100. Apparently there is something wrong in the math there, which should be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant