Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing tests #21

Open
16 of 17 tasks
robertpainsi opened this issue May 14, 2023 · 1 comment
Open
16 of 17 tasks

Add missing tests #21

robertpainsi opened this issue May 14, 2023 · 1 comment
Labels
improvement
Milestone
1.0.0

Comments

@robertpainsi
Copy link
Owner

robertpainsi commented May 14, 2023 •
edited
Loading

Fix and add more tests.

  • Create and fix helper methods for easily testing
  • Parser
  • Filtering
    • Callbacks
  • Schema
    • Group
    • Filter
    • Item
    • FilterData
  • Result
    • GroupResult
    • FilterResult
  • utils
    • findOne
    • getProperty
    • compareStrings
  • FilteringFlow (partially tested)
@robertpainsi robertpainsi added this to the 1.0.0 milestone May 14, 2023
@robertpainsi
Copy link
Owner Author

Issue moved to Closed in Roadmap 1.0.0 but still remains open because a (commented out) test for FilteringFlow throws an error I can't get rid of.

Failed to execute 'dispatchEvent' on 'EventTarget': parameter 1 is not of type 'Event'.

#34 may address this issue.

@robertpainsi robertpainsi moved this from Ready for development to Closed in Filtering.js - Roadmap 1.0.0 May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement
Projects
Filtering.js - Roadmap 1.0.0
Status: Closed
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@robertpainsi