-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS configuration with CMake 3.25.1 installed by Homebrew fails #2909
Comments
This is similar to robotology/robotology-superbuild#1090, that was fixed in YARP by #2822 and #1635 . In this case I do not know how to fix the issue as far as I know there is no programmatic way to check if a property is read-only in CMake, so we can just disable bundles on macOS as we did in the superbuild in robotology/robotology-superbuild#1092, by setting All the bundle machinery was added back in time by @francesco-romano (see #606), and people interested in these feature were macOS that discussed in #580, such as @kt10aan @vtikha @claudiofantacci . However I do not think anyone of them is using YARP anymore, and unless there is some macOS user interested in this feature, probably it make more sense to drop it (i.e. remove all code not executed if |
As a reference, I disabled macOS bundles in the superbuild back in April (see #2909) and nobody complained as far as I know. |
I still use YARP on macOS, I will try to give the issue a go, but it will take a few days as I am upgrading to Ventura now.On Dec 2, 2022, at 5:38, Silvio Traversaro ***@***.***> wrote:
However, unless there is some macOS user interested in this feature, probably it make more sense to drop it (i.e. remove all code not executed if YARP_DISABLE_MACOS_BUNDLES is ON) to reduce the mantainance burden.
As a reference, I disabled macOS bundles in the superbuild back in April (see #2909) and nobody complained as far as I know.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Great, thanks a lot @kt10aan ! Based on my initial super-local assessment the issue could be fixed if we had a way to understand which CMake properties are read-only, but perhaps there is some better solution that avoids to set/get some many arbitrary properties at all. |
Sorry for getting late with that. Apparently, as far as I can tell, the. quickest (but not that quick) solution would be some loop to get/set for all properties (maybe fewer with some regular expressions) or just hardcode them. Maybe this will change in some future version of CMake. Btw, I have stopped using the bundle option a long time ago. |
Describe the bug
Configuration fails with:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Configuration is successful.
The text was updated successfully, but these errors were encountered: