-
Notifications
You must be signed in to change notification settings - Fork 20
[BUG]: hal notifier functions return non-zero status #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Your C++ code is explicitly initializing the status to zero, but I believe the wrappers do not. Thad says these functions do not explicitly set the status value unless there's an error, so that's probably the problem. Requires an update to robotpy-build, but I should be able to push that tonight. (Thanks to Thad for pointing this out) |
Some of the Java versions of these functions do not return a status. That might also be appropriate. |
Please try installing robotpy/robotpy-build#254 and see if that addresses your issue. |
I'm might not be skilled enough to do the install. I did this install:
Then I get this:
|
That looks like you're missing the pybind11 submodule in robotpy-build. Try again after running |
Thanks @auscompgeek `` fixed my build problem. Thanks @virtuald This fixed the status return problem. Now when trying the same robotpy simulation I get:
|
Problem description
The functions
all return non-zero status in python, while similar c++ code returns 0 status.
e.g.:
See https://github.com/MikeStitt/pythonExperiments/tree/mostrobotpy-issue-165-20250423/cppRobot/robot for minimal c++ code to show that c++ does not have the issue.
See https://github.com/MikeStitt/pythonExperiments/tree/mostrobotpy-issue-165-20250423/pythonRobot for minimal python code to recreate the issue.
The c++ simulation output is:
The python simulation output is:
For the c++ code see: https://github.com/MikeStitt/pythonExperiments/blob/mostrobotpy-issue-165-20250423/cppRobot/robot/src/main/cpp/ExpTimedRobot.cpp#L33
For the python code see: https://github.com/MikeStitt/pythonExperiments/blob/mostrobotpy-issue-165-20250423/pythonRobot/exptimedrobotpy.py#L27
Operating System
MacOS
Installed Python Packages
Reproducible example code
The text was updated successfully, but these errors were encountered: