Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoquoting non-overridable #101

Open
Suor opened this issue Feb 23, 2018 · 5 comments
Open

Autoquoting non-overridable #101

Suor opened this issue Feb 23, 2018 · 5 comments

Comments

@Suor
Copy link
Contributor

Suor commented Feb 23, 2018

This makes impossible e.g. adding a reserved word, see Suor/sql-bricks-postgres#13

@prust
Copy link
Collaborator

prust commented Feb 23, 2018

@Suor: Yeah, it should be possible to add binary to the list by doing something like:

sql._reserved.binary = 'binary';

But that pollutes the global namespace, it'd be nice to add a way to extend this while leaving the original namespace alone, like we want to do for converters (#62). That'll be breaking change in 3.0, though, not something we can slip into 2.x.

@Suor
Copy link
Contributor Author

Suor commented Feb 23, 2018

Ah, yes this is possible. I looked that sql._reserved is never used and forget about shallowness of a copy. I will hack it for now. Same as with conversions. We are struggling without proper inheritance here.

@prust
Copy link
Collaborator

prust commented Feb 23, 2018

@Suor: Thanks

We are struggling without proper inheritance here.

Understood, that's next on my 3.x list.

@tamarzil
Copy link

Also - it would be great if we could set a custom value for '_autoQuoteChar' for the extension. In mysql identifiers are quoted with a backtick, not double quotes (unless setting a specific SQL mode).

@prust
Copy link
Collaborator

prust commented Jul 24, 2018

thx @tamarzil! I created a new Issue to track this (#104).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants