/api/movies only works on faceted properties - Fixed!

[mediabuff]

Try /api/movies with FacetGenreFacets = 'Short' and it works.

Try the same with Genres= 'Short' and it does not work

[mediabuff]

    public static Type GetUnderlyingType(PropertyInfo propertyInfo)
    {
        // Get the underlying type, checking if it is a Nullable<T>
        var underlyingType = Nullable.GetUnderlyingType(propertyInfo.PropertyType);

        // Determine the actual type to check IsEnum on (either the underlying type or the original type)
        var typeToCheck = underlyingType ?? propertyInfo.PropertyType;
        return typeToCheck;
    }

[mediabuff]

internal static class LuceneQueryBuilder
{
    internal static Query ConstructQuery<T>(IDictionary<string, string?>? searchFields, SearchType searchType)
        where T : IDocument
    {
        if (searchFields == null || searchFields.Count == 0 ||
            searchFields.All(p => string.IsNullOrWhiteSpace(p.Value)))
        {
            return new MatchAllDocsQuery();
        }

        var query = new BooleanQuery();
        var instance = Activator.CreateInstance<T>();
        foreach (var (fieldName, value) in searchFields)
        {
            var propertyInfo = instance.GetType().GetProperty(fieldName);

            // There were 2 problems in original code. Example ''class GetMoviesQuery.cs has  int? StartYear' vs 'class Movie having int StartYear'
            // First - not checking underlying type for a nullable type
            // Secondly - why even bother to check of 'string' value, as passed 'searchFields' is a dictionary of string values.
            // In fact this fill fail if the underlying field is non-string like an int - which need to passed as string to the Terms functions any way
#if false
            var type = DocumentConverterExtensions.GetUnderlyingType(propertyInfo);
#else
            var type = propertyInfo?.PropertyType;
#endif

#if false // disable see comments
            if (type == null || (type != typeof(string) && type != typeof(string[])))
            {
                continue;
            }
#endif 

            Query searchQuery = searchType switch
            {
                SearchType.ExactMatch => new TermQuery(new Term(fieldName, value)),
                SearchType.PrefixMatch => new PrefixQuery(new Term(fieldName, value)),
                SearchType.FuzzyMatch => new FuzzyQuery(new Term(fieldName, value)),
                _ => new TermQuery(new Term(fieldName, value))
            };

            query.Add(searchQuery, Occur.SHOULD);
        }

        return query;
    }
}