refactor(java-agent): replace resetForTesting with injectable Provider<Long> in AgentTelemetryStore

Author: buongarzoni

rollbar-java-agent/src/main/java/com/rollbar/agent/AgentTelemetryStore.java

@@ -1,6 +1,7 @@
 package com.rollbar.agent;
 
 import com.rollbar.api.payload.data.TelemetryEvent;
+import com.rollbar.notifier.provider.Provider;
 import com.rollbar.notifier.telemetry.RollbarTelemetryEventTracker;
 import com.rollbar.notifier.telemetry.TelemetryEventTracker;
 
@@ -21,7 +22,7 @@ public static List<TelemetryEvent> getAll() {
     return INSTANCE.getAll();
   }
 
-  public static void resetForTesting() {
-    INSTANCE = new RollbarTelemetryEventTracker(System::currentTimeMillis, 100);
+  public static void init(Provider<Long> timestampProvider) {
+    INSTANCE = new RollbarTelemetryEventTracker(timestampProvider, 100);
   }
 }

rollbar-java-agent/src/test/java/com/rollbar/agent/RollbarAgentTest.java

@@ -1,16 +1,20 @@
 package com.rollbar.agent;
 
+import com.rollbar.api.payload.data.TelemetryEvent;
 import com.rollbar.notifier.telemetry.TelemetryEventTracker;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
+import java.util.List;
+
 import static org.junit.jupiter.api.Assertions.*;
 
+
 public class RollbarAgentTest {
 
   @BeforeEach
   public void setUp() {
-    AgentTelemetryStore.resetForTesting();
+    AgentTelemetryStore.init(System::currentTimeMillis);
   }
 
   @Test
@@ -20,6 +24,22 @@ public void getTelemetryTracker_returnsSingletonInstance() {
     assertSame(first, second);
   }
 
+  @Test
+  public void init_withCustomTimestamp_usesProvidedTimestamp() {
+    long fixedTime = 1_000_000L;
+    AgentTelemetryStore.init(() -> fixedTime);
+
+    AgentTelemetryStore.getInstance().recordManualEventFor(
+        com.rollbar.api.payload.data.Level.WARNING,
+        com.rollbar.api.payload.data.Source.CLIENT,
+        "test"
+    );
+
+    List<TelemetryEvent> events = AgentTelemetryStore.getInstance().getAll();
+    assertEquals(1, events.size());
+    assertEquals(fixedTime, events.get(0).asJson().get("timestamp_ms"));
+  }
+
   @Test
   public void urlSanitizer_stripsQueryAndFragment() {
     String sanitized = UrlSanitizer.sanitize("https://api.example.com/path?token=secret#section");

rollbar-java-agent/src/test/java/com/rollbar/agent/instrumentation/HttpURLConnectionInstrumentationTest.java

@@ -26,7 +26,7 @@ public class HttpURLConnectionInstrumentationTest {
   public void setUp() {
     server = new WireMockServer(WireMockConfiguration.wireMockConfig().dynamicPort());
     server.start();
-    AgentTelemetryStore.resetForTesting();
+    AgentTelemetryStore.init(System::currentTimeMillis);
     NetworkEventBridge.resetRecordedForTesting();
   }
 

rollbar-java-agent/src/test/java/com/rollbar/agent/instrumentation/JavaHttpClientInstrumentationTest.java

@@ -29,7 +29,7 @@ public void setUp() {
     server = new WireMockServer(WireMockConfiguration.wireMockConfig().dynamicPort());
     server.start();
     client = HttpClient.newHttpClient();
-    AgentTelemetryStore.resetForTesting();
+    AgentTelemetryStore.init(System::currentTimeMillis);
     NetworkEventBridge.resetRecordedForTesting();
   }