Fix some keys with no timeout

Author: roniemartinez

decorator_rate_limiting.py

@@ -16,10 +16,10 @@ def _rate_per_second(function):
         def __rate_per_second(*args, **kwargs):
             client = get_redis_client()
             key = f"rate-limit:{int(time.time())}"
-            if client.incr(key) > count:
-                if client.ttl(key) == -1:  # timeout is not set
-                    client.expire(key, 1)  # expire in 1 second
+            if int(client.incr(key)) > count:
                 raise RateLimitExceeded
+            if client.ttl(key) == -1:  # timeout is not set
+                client.expire(key, 1)  # expire in 1 second
             return function(*args, *kwargs)
         return __rate_per_second
     return _rate_per_second

naive_rate_limiting.py

@@ -14,10 +14,10 @@
 def rate_per_second(function, count):
     client = get_redis_client()
     key = f"rate-limit:{int(time.time())}"
-    if client.incr(key) > count:
-        if client.ttl(key) == -1:  # timeout is not set
-            client.expire(key, 1)  # expire in 1 second
+    if int(client.incr(key)) > count:
         raise RateLimitExceeded
+    if client.ttl(key) == -1:  # timeout is not set
+        client.expire(key, 1)  # expire in 1 second
     return function()