Merge pull request #4 from rootinc/bug/file-visibility

jaredrhodes · web-flow · commit 4faf3120a0d4 · 2020-10-20T14:02:15.000-04:00
Remove "public-read" from local/public/S3
diff --git a/src/FileModel.php b/src/FileModel.php
@@ -132,9 +132,7 @@ public static function upload(UploadedFile $file, $relative_directory = null, $p
 				: '');
 
 		// Public or private
-		$is_s3 = $filesystem_driver === 's3';
-		$visibility_setting = !$is_s3 ? 'public' : 'public-read';
-		$visibility = $public ? $visibility_setting : 'private';
+		$visibility = $public ? 'public' : 'private';
 
 		return $disk->putFileAs($directory, $file, $file->getClientOriginalName(), $visibility);
 	}

Original file line number	Diff line number	Diff line change
`@@ -132,9 +132,7 @@ public static function upload(UploadedFile $file, $relative_directory = null, $p`
`132`	`132`	`: '');`
`133`	`133`
`134`	`134`	`// Public or private`
`135`		`- $is_s3 = $filesystem_driver === 's3';`
`136`		`- $visibility_setting = !$is_s3 ? 'public' : 'public-read';`
`137`		`- $visibility = $public ? $visibility_setting : 'private';`
	`135`	`+ $visibility = $public ? 'public' : 'private';`
`138`	`136`
`139`	`137`	`return $disk->putFileAs($directory, $file, $file->getClientOriginalName(), $visibility);`
`140`	`138`	`}`