fix file controller test

Author: Dan Jewett

src/FileBaseControllerTest.php

@@ -8,23 +8,43 @@
 use Illuminate\Foundation\Testing\DatabaseTransactions;
 
 use App\File;
+use App\User;
 
 class FileBaseControllerTest extends TestCase
 {
     use RefreshDatabase;
 
-    protected $user_index;
-    protected $user_index_error;
-    protected $user_create;
-    protected $user_update;
-    protected $user_delete;
+    protected function getUserForIndex()
+    {
+        return factory(User::class)->create();
+    }
+
+    protected function getUserForIndexError()
+    {
+        return factory(User::class)->create();
+    }
+
+    protected function getUserForCreate()
+    {
+        return factory(User::class)->create();
+    }
+
+    protected function getUserForUpdate()
+    {
+        return factory(User::class)->create();
+    }
+
+    protected function getUserForDelete()
+    {
+        return factory(User::class)->create();
+    }
 
     /** @test */
     public function it_checks_if_index_work()
     {
         $files = factory(File::class, 4)->create();
 
-        $response = $this->actingAs($this->user_index)->json('GET', route('api.files.index'));
+        $response = $this->actingAs($this->getUserForIndex())->json('GET', route('api.files.index'));
 
         $response->assertStatus(200);
         $response->assertJson([
@@ -42,7 +62,7 @@ public function it_checks_if_index_gives_error()
     {
         $files = factory(File::class, 4)->create();
 
-        $response = $this->actingAs($this->user_index_error)->json('GET', route('api.files.index'));
+        $response = $this->actingAs($this->getUserForIndexError())->json('GET', route('api.files.index'));
 
         $response->assertStatus(403);
         $response->assertJson([
@@ -56,7 +76,7 @@ public function it_checks_if_index_gives_error()
     /** @test */
     public function it_checks_create_works()
     {
-        $response = $this->actingAs($this->user_create)->json('POST', route('api.files.store', [
+        $response = $this->actingAs($this->getUserForCreate())->json('POST', route('api.files.store', [
             'file_name' => 'something cute.png',
             'file_type' => 'image/png',
             'file_data' => $this->get1x1RedPixelImage()
@@ -78,7 +98,7 @@ public function it_checks_update_works()
     {
         $file = factory(File::class)->create();
 
-        $response = $this->actingAs($this->user_update)->json('PUT', route('api.files.update', [
+        $response = $this->actingAs($this->getUserForUpdate())->json('PUT', route('api.files.update', [
             'file' => $file->id,
             'file_name' => 'something cute.png',
             'file_type' => 'image/png',
@@ -101,7 +121,7 @@ public function it_checks_delete_works()
     {
         $file = factory(File::class)->create();
 
-        $response = $this->actingAs($this->user_delete)->json('DELETE', route('api.files.destroy', [
+        $response = $this->actingAs($this->getUserForDelete())->json('DELETE', route('api.files.destroy', [
             'file' => $file->id
         ]));
 

templates/FileControllerTest.php

@@ -8,12 +8,28 @@
 
 class FileControllerTest extends FileBaseControllerTest
 {
-    public function __construct()
+    protected function getUserForIndex()
     {
-        $this->user_index = factory(User::class)->create();
-        $this->user_index_error = factory(User::class)->create();
-        $this->user_create = factory(User::class)->create();
-        $this->user_update = factory(User::class)->create();
-        $this->user_delete = factory(User::class)->create();
+        return factory(User::class)->states("superadmin")->create();
+    }
+
+    protected function getUserForIndexError()
+    {
+        return factory(User::class)->states("user")->create();
+    }
+
+    protected function getUserForCreate()
+    {
+        return factory(User::class)->states("superadmin")->create();
+    }
+
+    protected function getUserForUpdate()
+    {
+        return factory(User::class)->states("superadmin")->create();
+    }
+
+    protected function getUserForDelete()
+    {
+        return factory(User::class)->states("superadmin")->create();
     }
 }