Skip to content
This repository was archived by the owner on May 14, 2024. It is now read-only.

Commit 545759e

Browse files
committed
Further clarification in cran-comments.md
1 parent 6849df0 commit 545759e

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

cran-comments.md

+7-4
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,13 @@ fetched using `tryCatch()` and then again without
3636
is because `janitor::remove_empty` is a new function in a to-be-released version
3737
of `janitor`. Sam Firke has a alerted me to the coming change so I've
3838
incorporated the new functionality to future proof `bomrang`. See lines
39-
74-83 of get_weather_bulletins.R for the if statement that checks the version
40-
of janitor, this allows it to work even before the new version is released. I've
41-
tested with the current version of `janitor` and the development version as well
42-
to be sure it functions as desired.
39+
74-83 of get_weather_bulletins.R for the `if` statement provided by Sam that
40+
checks the version of `janitor`, this allows it to work even before the new
41+
version is released. I've tested with the current version of `janitor` and the
42+
development version as well to be sure it functions as desired.
43+
44+
Future versions of `bomrang` will remove this and require v1.0.0 of `janitor` in
45+
the DESCRIPTION file.
4346

4447
## Reverse dependencies
4548

0 commit comments

Comments
 (0)