Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Integrate with gitcreds #95

Open
Aariq opened this issue Sep 5, 2024 · 3 comments · May be fixed by #96
Open

[Feature request] Integrate with gitcreds #95

Aariq opened this issue Sep 5, 2024 · 3 comments · May be fixed by #96

Comments

@Aariq
Copy link

Aariq commented Sep 5, 2024

I store my GitHub PAT with gitcreds::gitcreds_set() and I prefer not to store it in .Renviron (just in case). It'd be nice if gistr could discover my token.

@sckott
Copy link
Contributor

sckott commented Sep 5, 2024

hey Eric, nice to hear from you. I no longer maintain this pkg. We kinda have a new maintainer, but not sure if he's actively engaged (see #93 ) soo 🤷🏽

@ScientificProgrammer
Copy link
Contributor

"I store my GitHub PAT with gitcreds::gitcreds_set() and I prefer not to store it in .Renviron (just in case). It'd be nice if gistr could discover my token."

Hi Aariq,

After I discovered (and figured out how to use) the r-lib/gitcreds package, like you, I stopped storing credentials in .Renviron. I'm embarrassed to acknowledge as a maintainer of ropensci/gistr, I had no idea that it didn't use gitcreds.

I'll take a look at this issue this weekend. However, I need to set expectations appropriately. My understanding of gitcreds is limited to using its most basic features from an end user's POV to manage git credentials. I have absolutely no idea how to configure a package to interrogate gitcreds. Therefore, unless the process for integrating a gitcreds check into a package is easy, I'm going to need some time to figure it out.

In that regard, if you have any suggestions for me, please let me know!

@Aariq
Copy link
Author

Aariq commented Sep 6, 2024

A similar project, gistillery, appears to work with gitcreds, and was inspired by gistr. Might be as simple as copying some of this code: https://github.com/jthomasmock/gistillery/blob/3b5e91840dcf859e4ececde87b03c27fed5337b2/R/git_auth.R#L27-L58

@Aariq Aariq linked a pull request Oct 26, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants