Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure on R-universe #90

Open
maelle opened this issue Feb 7, 2025 · 3 comments
Open

test failure on R-universe #90

maelle opened this issue Feb 7, 2025 · 3 comments
Assignees

Comments

@maelle
Copy link
Member

maelle commented Feb 7, 2025

From https://ropensci.r-universe.dev/builds

We see

 Running the tests in ‘tests/testthat.R’ failed.
  Last 13 lines of output:
      'test-get_satellite_imagery.R:29:3', 'test-get_stations_metadata.R:5:15',
      'test-get_stations_metadata.R:33:15', 'test-get_stations_metadata.R:66:15',
      'test-get_stations_metadata.R:123:15', 'test-get_stations_metadata.R:152:15',
      'test-get_stations_metadata.R:183:17'
    
    ══ Failed tests ════════════════════════════════════════════════════════════════
    ── Failure ('test-find_stations_in.R:11:3'): find_stations_in() works with {sf} polygon ──
    dim(x) (`actual`) not identical to c(679L, 11L) (`expected`).
    
      `actual`: 672 11
    `expected`: 679 11
    
    [ FAIL 1 | WARN 2 | SKIP 106 | PASS 81 ]
@bozaah
Copy link
Collaborator

bozaah commented Feb 20, 2025

Thank you for flagging this Maelle. There are some changes being implemented by the team that handles the weather station infrastructure and the API. The issue #91 is also related and leading to some of the failed tests.

@bozaah
Copy link
Collaborator

bozaah commented Feb 20, 2025

Fixes and updates to be rolled out after PR 92 is resolved.

@maelle
Copy link
Member Author

maelle commented Feb 20, 2025

Thank you for the update! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants