fix: blocklist duplicate typesupport extern declarations

Add blocklist patterns to generate_bindings.py to prevent bindgen from
generating typesupport function declarations that clash with vendored
message crates (rosidl_generator_rs generates these with *const c_void).

Remove existing duplicate extern declarations from all 4 generated
binding files for:
- rosidl_typesupport_c__get_message_type_support_handle__action_msgs__*
- rosidl_typesupport_c__get_service_type_support_handle__action_msgs__*

Also fix clippy useless_vec warning in build.rs.

Closes #559

Author: gsokoll

rclrs/build.rs

@@ -16,7 +16,7 @@ fn get_env_var_or_abort(env_var: &'static str) -> String {
 fn main() {
     println!(
         "cargo:rustc-check-cfg=cfg(ros_distro, values(\"{}\"))",
-        vec!["humble", "jazzy", "kilted", "rolling"].join("\", \"")
+        ["humble", "jazzy", "kilted", "rolling"].join("\", \"")
     );
     let ros_distro = if let Ok(value) = env::var(ROS_DISTRO) {
         value

rclrs/generate_bindings.py

@@ -46,6 +46,14 @@ def main():
     bindgen_command.append('rcutils_.*')
     bindgen_command.append('--allowlist-var')
     bindgen_command.append('rosidl_.*')
+    # Blocklist typesupport functions that are already declared in vendored message crates
+    # (rosidl_generator_rs generates these with *const c_void return type)
+    bindgen_command.append('--blocklist-function')
+    bindgen_command.append('rosidl_typesupport_.*__get_message_type_support_handle__.*')
+    bindgen_command.append('--blocklist-function')
+    bindgen_command.append('rosidl_typesupport_.*__get_service_type_support_handle__.*')
+    bindgen_command.append('--blocklist-function')
+    bindgen_command.append('rosidl_typesupport_.*__get_action_type_support_handle__.*')
     bindgen_command.append('--no-layout-tests')
     bindgen_command.append('--default-enum-style')
     bindgen_command.append('rust')

rclrs/src/rcl_bindings_generated_humble.rs

@@ -3404,10 +3404,6 @@ pub struct action_msgs__msg__GoalInfo__Sequence {
     pub size: usize,
     pub capacity: usize,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalInfo(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__msg__GoalStatus {
@@ -3421,19 +3417,11 @@ pub struct action_msgs__msg__GoalStatus__Sequence {
     pub size: usize,
     pub capacity: usize,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatus(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__msg__GoalStatusArray {
     pub status_list: action_msgs__msg__GoalStatus__Sequence,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatusArray(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__srv__CancelGoal_Request {
@@ -3445,18 +3433,6 @@ pub struct action_msgs__srv__CancelGoal_Response {
     pub return_code: i8,
     pub goals_canceling: action_msgs__msg__GoalInfo__Sequence,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Request(
-    ) -> *const rosidl_message_type_support_t;
-}
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Response(
-    ) -> *const rosidl_message_type_support_t;
-}
-extern "C" {
-    pub fn rosidl_typesupport_c__get_service_type_support_handle__action_msgs__srv__CancelGoal(
-    ) -> *const rosidl_service_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct rosidl_action_type_support_t {

rclrs/src/rcl_bindings_generated_jazzy.rs

@@ -8530,10 +8530,6 @@ pub struct action_msgs__msg__GoalInfo__Sequence {
     pub size: usize,
     pub capacity: usize,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalInfo(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__msg__GoalStatus {
@@ -8547,19 +8543,11 @@ pub struct action_msgs__msg__GoalStatus__Sequence {
     pub size: usize,
     pub capacity: usize,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatus(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__msg__GoalStatusArray {
     pub status_list: action_msgs__msg__GoalStatus__Sequence,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatusArray(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__srv__CancelGoal_Request {
@@ -8571,22 +8559,10 @@ pub struct action_msgs__srv__CancelGoal_Response {
     pub return_code: i8,
     pub goals_canceling: action_msgs__msg__GoalInfo__Sequence,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Request(
-    ) -> *const rosidl_message_type_support_t;
-}
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Response(
-    ) -> *const rosidl_message_type_support_t;
-}
 extern "C" {
     pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Event(
     ) -> *const rosidl_message_type_support_t;
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_service_type_support_handle__action_msgs__srv__CancelGoal(
-    ) -> *const rosidl_service_type_support_t;
-}
 extern "C" {
     pub fn rosidl_typesupport_c__create_service_event_message__action_msgs__srv__CancelGoal(
         info: *const rosidl_service_introspection_info_t,

rclrs/src/rcl_bindings_generated_kilted.rs

@@ -8392,10 +8392,6 @@ pub struct action_msgs__msg__GoalInfo__Sequence {
     pub size: usize,
     pub capacity: usize,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalInfo(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__msg__GoalStatus {
@@ -8409,19 +8405,11 @@ pub struct action_msgs__msg__GoalStatus__Sequence {
     pub size: usize,
     pub capacity: usize,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatus(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__msg__GoalStatusArray {
     pub status_list: action_msgs__msg__GoalStatus__Sequence,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatusArray(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__srv__CancelGoal_Request {
@@ -8433,22 +8421,10 @@ pub struct action_msgs__srv__CancelGoal_Response {
     pub return_code: i8,
     pub goals_canceling: action_msgs__msg__GoalInfo__Sequence,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Request(
-    ) -> *const rosidl_message_type_support_t;
-}
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Response(
-    ) -> *const rosidl_message_type_support_t;
-}
 extern "C" {
     pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Event(
     ) -> *const rosidl_message_type_support_t;
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_service_type_support_handle__action_msgs__srv__CancelGoal(
-    ) -> *const rosidl_service_type_support_t;
-}
 extern "C" {
     pub fn rosidl_typesupport_c__create_service_event_message__action_msgs__srv__CancelGoal(
         info: *const rosidl_service_introspection_info_t,

rclrs/src/rcl_bindings_generated_rolling.rs

@@ -8395,10 +8395,6 @@ pub struct action_msgs__msg__GoalInfo__Sequence {
     pub size: usize,
     pub capacity: usize,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalInfo(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__msg__GoalStatus {
@@ -8412,19 +8408,11 @@ pub struct action_msgs__msg__GoalStatus__Sequence {
     pub size: usize,
     pub capacity: usize,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatus(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__msg__GoalStatusArray {
     pub status_list: action_msgs__msg__GoalStatus__Sequence,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__msg__GoalStatusArray(
-    ) -> *const rosidl_message_type_support_t;
-}
 #[repr(C)]
 #[derive(Debug)]
 pub struct action_msgs__srv__CancelGoal_Request {
@@ -8436,22 +8424,10 @@ pub struct action_msgs__srv__CancelGoal_Response {
     pub return_code: i8,
     pub goals_canceling: action_msgs__msg__GoalInfo__Sequence,
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Request(
-    ) -> *const rosidl_message_type_support_t;
-}
-extern "C" {
-    pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Response(
-    ) -> *const rosidl_message_type_support_t;
-}
 extern "C" {
     pub fn rosidl_typesupport_c__get_message_type_support_handle__action_msgs__srv__CancelGoal_Event(
     ) -> *const rosidl_message_type_support_t;
 }
-extern "C" {
-    pub fn rosidl_typesupport_c__get_service_type_support_handle__action_msgs__srv__CancelGoal(
-    ) -> *const rosidl_service_type_support_t;
-}
 extern "C" {
     pub fn rosidl_typesupport_c__create_service_event_message__action_msgs__srv__CancelGoal(
         info: *const rosidl_service_introspection_info_t,