Skip to content

draft: Remove vendoring freetype and zlib on Windows #1636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
mjcarroll wants to merge 3 commits into
base: rolling
Choose a base branch
from
Draft

draft: Remove vendoring freetype and zlib on Windows #1636

mjcarroll wants to merge 3 commits into from

Conversation

@mjcarroll
Copy link
Member

@mjcarroll mjcarroll commented Dec 3, 2025

Opening as draft, because this isn't the entire extent of necessary changes, but wanted to save where I was at.

@mjcarroll mjcarroll requested a review from ahcorde December 3, 2025 23:28
@mjcarroll mjcarroll self-assigned this Dec 3, 2025
@mjcarroll mjcarroll force-pushed the mjcarroll/remove_windows_vendor branch 2 times, most recently from c18d851 to f6ae709 Compare December 3, 2025 23:30
@mjcarroll mjcarroll changed the base branch from rolling to ahcorde/rolling/removed_yamlcpp_vendor December 3, 2025 23:30
@ahcorde
Copy link
Contributor

ahcorde commented Dec 4, 2025

Related ros2/ros2#1774

@ahcorde
Copy link
Contributor

ahcorde commented Dec 4, 2025

I'm getting an error related with lib/zlibstatic.lib

@ahcorde
Copy link
Contributor

ahcorde commented Dec 4, 2025

Removing these line the issues is fixed

https://github.com/ros2/rviz/blob/mjcarroll/remove_windows_vendor/rviz_ogre_vendor/rviz_ogre_vendor-extras.cmake.in#L103-L109

Maybe pixi is not bringing the static lib for zlib.

@ahcorde ahcorde mentioned this pull request Dec 5, 2025
Merged
@ahcorde ahcorde changed the base branch from ahcorde/rolling/removed_yamlcpp_vendor to rolling December 5, 2025 12:15
@ahcorde ahcorde force-pushed the mjcarroll/remove_windows_vendor branch from f6ae709 to 16a3a14 Compare December 5, 2025 12:15
@ahcorde
Suggestions (#1638)
fdc470e 
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
@ahcorde
Copy link
Contributor

ahcorde commented Dec 5, 2025

Pulls: #1636
Gist: https://gist.githubusercontent.com/ahcorde/ab3989598448ef70ff1249b0d672fe48/raw/125f9574cb9d6ddd4a650b34bda04ada0823e87d/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_ogre_vendor
TEST args: --packages-above rviz_ogre_vendor
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17699

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@ahcorde
Copy link
Contributor

ahcorde commented Dec 9, 2025

Pulls: #1636
Gist: https://gist.githubusercontent.com/ahcorde/f3434355d7d61adbc2cf95005583769e/raw/125f9574cb9d6ddd4a650b34bda04ada0823e87d/ros2.repos
BUILD args: --packages-above-and-dependencies rviz_ogre_vendor
TEST args: --packages-above rviz_ogre_vendor
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17727

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde Awaiting requested review from ahcorde

Assignees

@mjcarroll mjcarroll

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mjcarroll @ahcorde