Modify updateQuality method

Modify updateQuality method in the gilded-rose.ts file

Signed-off-by: Alexandra Stroiu <[email protected]>

Author: alexandrastroiu

app/gilded-rose.ts

@@ -28,24 +28,22 @@ export class GildedRose {
           qualityDifference *= 2;
         }
 
-        if (this.items[i].name != "Aged Brie" && this.items[i].name != "Backstage passes to a TAFKAL80ETC concert") {
-          if (this.items[i].quality > 0) {
-            this.items[i].quality = this.items[i].quality >= qualityDifference ? this.items[i].quality - qualityDifference : 0;
-          }
+        if (this.items[i].name != "Aged Brie" && this.items[i].name != "Backstage passes to a TAFKAL80ETC concert" && this.items[i].quality > 0) {
+          this.items[i].quality = this.items[i].quality >= qualityDifference ? (this.items[i].quality - qualityDifference) : 0;
         }
 
         if (this.items[i].name == "Aged Brie" && this.items[i].quality < 50) {
-          this.items[i].quality = this.items[i].quality + qualityDifference <= 50 ? this.items[i].quality + qualityDifference : 50;
+          this.items[i].quality = (this.items[i].quality + qualityDifference) <= 50 ? (this.items[i].quality + qualityDifference) : 50;
         }
 
         if (this.items[i].name == "Backstage passes to a TAFKAL80ETC concert" && this.items[i].quality < 50) {
           if (this.items[i].sellIn > 10) {
             this.items[i].quality += qualityDifference;
           } else if (5 < this.items[i].sellIn && this.items[i].sellIn <= 10) {
-            this.items[i].quality = this.items[i].quality + 2 * qualityDifference <= 50 ? this.items[i].quality + 2 * qualityDifference : 50;
+            this.items[i].quality = (this.items[i].quality + 2 * qualityDifference) <= 50 ? (this.items[i].quality + 2 * qualityDifference) : 50;
           } else if (0 < this.items[i].sellIn && this.items[i].sellIn <= 5) {
-            this.items[i].quality = this.items[i].quality + 3 * qualityDifference <= 50 ? this.items[i].quality + 3 * qualityDifference : 50;
-          } else {
+            this.items[i].quality = (this.items[i].quality + 3 * qualityDifference) <= 50 ? (this.items[i].quality + 3 * qualityDifference) : 50;
+          } else if (this.items[i].sellIn <= 0){
             this.items[i].quality = 0;
           }
         }

test/jest/gilded-rose.spec.ts

@@ -158,9 +158,9 @@ describe("Gilded Rose", () => {
 
     expect(items[0].sellIn).toBe(2);
     expect(items[0].quality).toBe(4);
-    expect(items[2].sellIn).toBe(-1);
+    expect(items[1].sellIn).toBe(-1);
+    expect(items[1].quality).toBe(0);
+    expect(items[2].sellIn).toBe(-4);
     expect(items[2].quality).toBe(0);
-    expect(items[3].sellIn).toBe(-4);
-    expect(items[3].quality).toBe(0);
   });
 });