Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blank lines are inserted. Editor never released. #8

Closed
jidanni opened this issue Mar 10, 2023 · 3 comments
Closed

Blank lines are inserted. Editor never released. #8

jidanni opened this issue Mar 10, 2023 · 3 comments
Assignees
Labels

Comments

@jidanni
Copy link

jidanni commented Mar 10, 2023

I followed https://github.com/rosmanov/chrome-bee/wiki/Configuration-in-Chrome:
20230310T140512
20230310T142840

OK, editing a file on https://commons.wikimedia.org/ , before I hit CTRL+E it looks like:
20230310T140314
Upon hitting CTRL+E it just becomes interspersed with blank lines, and read-only:
20230310T140404

OK. Be sure to remind people at the bottom of
https://github.com/rosmanov/chrome-bee/wiki/Configuration-in-Chrome
that there is one more step needed (install the .deb etc.)!

OK, now the editor works, but the blank lines are still there.
(I suppose maybe you are guessing the person is using a CRLF computer, but we are just using Linux LFs?)
And when we are finished editing the textbox is still readonly, meaning you haven't got the signal from the editor that it is finished.

Tested on Debian Sid.

@jidanni jidanni changed the title No editor is opened. Just blank line are inserted. Blank lines are inserted. Editor never released. Mar 10, 2023
@rosmanov rosmanov added the bug label Mar 10, 2023
@rosmanov rosmanov self-assigned this Mar 10, 2023
@rosmanov
Copy link
Owner

rosmanov commented Mar 10, 2023

OK. Be sure to remind people at the bottom of
https://github.com/rosmanov/chrome-bee/wiki/Configuration-in-Chrome
that there is one more step needed (install the .deb etc.)!

I thought people usually read the main README.md first. But I was wrong.

Added a note at the top of the page:

⚠️ Please note that the browser extension will not work without the host application being installed.


OK, now the editor works, but the blank lines are still there.
(I suppose maybe you are guessing the person is using a CRLF computer, but we are just using Linux LFs?)

There is no intended intervention to the text processing on beectl side. The application just reads content from the browser and passes it through to a temporary file. Then the file is opened with the editor binary as {editor-command} {temporary-file}.

As a first step, I tried to reproduce this issue on Fedora Linux(as I think there should not be a big difference with Debian, actually) with gvim, and it worked without issues:

Screencast.from.2023-03-10.11-39-57.webm

Do you think your editor could convert newlines to CRLF? I'm not familiar with emacs, sorry. Did you try using a simple editor for a test?

I guess, the page you tried to edit might contain CRLF line endings that might be not apparent on the web page. What if you just copy the textarea content and paste it into the editor using just the clipboard, will the line endings look correct?

Thanks.

@jidanni
Copy link
Author

jidanni commented Mar 11, 2023

What was probably going on is interference from the website:
fregante/GhostText#249

Anyway I didn't test further because they have emacs ELPA, so I ended up using theirs.

Also about reminding people: you might also want to warn even one futhther time in the bottom of the file too, not just the top, for us with extra short memories :-)

@rosmanov
Copy link
Owner

👌 Yes, it might be due to some “mode” on the website. I’m closing the issue then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants