Skip to content

Commit 2ec5b8b

Browse files
committed
Make SpecLockMap and freeze_on_smi warnings fatal by default.
1 parent e1d0097 commit 2ec5b8b

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/PerfCounters_x86.h

+4-4
Original file line numberDiff line numberDiff line change
@@ -351,10 +351,10 @@ static void check_for_zen_speclockmap() {
351351
} else {
352352
LOG(debug) << "SpecLockMap is not disabled";
353353
if (!Flags::get().force_things) {
354-
fprintf(stderr,
354+
CLEAN_FATAL() <<
355355
"On Zen CPUs, rr will not work reliably unless you disable the "
356356
"hardware SpecLockMap optimization.\nFor instructions on how to "
357-
"do this, see https://github.com/rr-debugger/rr/wiki/Zen\n");
357+
"do this, see https://github.com/rr-debugger/rr/wiki/Zen\n";
358358
} else {
359359
cpu_improperly_configured = true;
360360
}
@@ -381,15 +381,15 @@ static void check_for_freeze_on_smi() {
381381
} else if (freeze_on_smi == '0') {
382382
LOG(warn) << "freeze_on_smi is not set";
383383
if (!Flags::get().force_things) {
384-
fprintf(stderr,
384+
CLEAN_FATAL() <<
385385
"Freezing performance counters on SMIs should be enabled for maximum rr\n"
386386
"reliability on Comet Lake and later CPUs. To manually enable this setting, run\n"
387387
"\techo 1 | sudo tee /sys/devices/cpu/freeze_on_smi\n"
388388
"On systemd systems, consider putting\n"
389389
"'w /sys/devices/cpu/freeze_on_smi - - - - 1' into /etc/tmpfiles.d/10-rr.conf\n"
390390
"to automatically apply this setting on every reboot.\n"
391391
"See 'man 5 sysfs', 'man 5 tmpfiles.d'.\n"
392-
"If you are seeing this message, the setting has not been enabled.\n");
392+
"If you are seeing this message, the setting has not been enabled.\n";
393393
} else {
394394
cpu_improperly_configured = true;
395395
}

0 commit comments

Comments
 (0)