Change debugger_launch_command debugger_name to be const string&

Author: rocallahan

src/GdbServer.cc

@@ -1613,7 +1613,7 @@ void GdbServer::serve_replay(const ConnectionFlags& flags) {
     DEBUG_ASSERT(nwritten == sizeof(params));
   } else {
     vector<string> cmd = debugger_launch_command(t, flags.dbg_host, port,
-        flags.serve_files, flags.debugger_name.c_str());
+        flags.serve_files, flags.debugger_name);
     fprintf(stderr, "Launch debugger with\n  %s\n", to_shell_string(cmd).c_str());
   }
 

src/launch_debugger.cc

@@ -171,7 +171,7 @@ string saved_debugger_launch_command;
 vector<string> debugger_launch_command(Task* t, const string& host,
                                        unsigned short port,
                                        bool serve_files,
-                                       const char* debugger_name) {
+                                       const string& debugger_name) {
   vector<string> cmd;
   cmd.push_back(debugger_name);
   push_default_gdb_options(cmd, serve_files);

src/launch_debugger.h

@@ -23,7 +23,7 @@ void launch_debugger(ScopedFd& params_pipe_fd, const std::string& debugger_file_
 std::vector<std::string> debugger_launch_command(Task* t, const std::string& host,
                                                  unsigned short port,
                                                  bool serve_files,
-                                                 const char* debugger_name);
+                                                 const std::string& debugger_name);
 
 /**
  * Convert the command line to a string containing quoted parameters.