Skip to content

Commit a434500

Browse files
committed
refactor: remove nice to have targets/features
1 parent ce8d378 commit a434500

File tree

1 file changed

+1
-16
lines changed

1 file changed

+1
-16
lines changed

src/MSBuild.Sdk.SqlProj/Sdk/Sdk.targets

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -313,9 +313,6 @@
313313

314314
<!-- ===== Container publish (experimental) : configuration ===== -->
315315
<PropertyGroup>
316-
<!-- Container CLI to invoke (typically 'docker') -->
317-
<ContainerRuntime>docker</ContainerRuntime>
318-
319316
<!-- Dockerfile that builds the publisher image (installs sqlpackage, copies dacpacs) -->
320317
<ContainerDockerfile>$(MSBuildThisFileDirectory)..\tools\container\sqlpackage.Dockerfile</ContainerDockerfile>
321318

@@ -377,19 +374,7 @@
377374
DependsOnTargets="PrepareContainerDacpac">
378375
<Message Text="Building container $(ContainerImageName):$(ContainerImageTag)"
379376
Importance="high" />
380-
<Exec Command='"$(ContainerRuntime)" build -f "$(ContainerDockerfile)" -t "$(ContainerImageName):$(ContainerImageTag)" --build-arg SQLPACKAGE_VERSION=$(SqlPackageVersion) --build-arg DACPAC_NAME=$(ContainerDacpacName) "$(MSBuildProjectDirectory)"'
381-
IgnoreExitCode="false" />
382-
</Target>
383-
384-
<!--
385-
PushContainer
386-
Pushes to the registry implied by ContainerImageName (e.g., 'ghcr.io/org/name').
387-
Ensure you've run 'docker login' (or equivalent) for that registry first.
388-
-->
389-
<Target Name="PushContainer">
390-
<Message Text="Pushing container $(ContainerImageName):$(ContainerImageTag)"
391-
Importance="high" />
392-
<Exec Command='"$(ContainerRuntime)" push "$(ContainerImageName):$(ContainerImageTag)"'
377+
<Exec Command='docker build -f "$(ContainerDockerfile)" -t "$(ContainerImageName):$(ContainerImageTag)" --build-arg SQLPACKAGE_VERSION=$(SqlPackageVersion) --build-arg DACPAC_NAME=$(ContainerDacpacName) "$(MSBuildProjectDirectory)"'
393378
IgnoreExitCode="false" />
394379
</Target>
395380
</Project>

0 commit comments

Comments
 (0)