Skip to content

Commit 9a7a47e

Browse files
committed
Indicate that replay no longer needs the queue, as added nodes should already be in the correct order for a single pass
1 parent e90b18b commit 9a7a47e

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

packages/rrweb/src/replay/index.ts

+7-7
Original file line numberDiff line numberDiff line change
@@ -1474,7 +1474,7 @@ export class Replayer {
14741474
const legacy_missingNodeMap: missingNodeMap = {
14751475
...this.legacy_missingNodeRetryMap,
14761476
};
1477-
const queue: addedNodeMutation[] = [];
1477+
const legacy_queue: addedNodeMutation[] = [];
14781478

14791479
// next not present at this moment
14801480
const nextNotInDOM = (mutation: addedNodeMutation) => {
@@ -1506,7 +1506,7 @@ export class Replayer {
15061506
// is newly added document, maybe the document node of an iframe
15071507
return this.newDocumentQueue.push(mutation);
15081508
}
1509-
return queue.push(mutation);
1509+
return legacy_queue.push(mutation);
15101510
}
15111511

15121512
if (mutation.node.isShadow) {
@@ -1526,7 +1526,7 @@ export class Replayer {
15261526
next = mirror.getNode(mutation.nextId);
15271527
}
15281528
if (nextNotInDOM(mutation)) {
1529-
return queue.push(mutation);
1529+
return legacy_queue.push(mutation);
15301530
}
15311531

15321532
if (mutation.node.rootId && !mirror.getNode(mutation.node.rootId)) {
@@ -1708,10 +1708,10 @@ export class Replayer {
17081708
});
17091709

17101710
const startTime = Date.now();
1711-
while (queue.length) {
1712-
// transform queue to resolve tree
1713-
const resolveTrees = queueToResolveTrees(queue);
1714-
queue.length = 0;
1711+
while (legacy_queue.length) {
1712+
// transform legacy_queue to resolve tree
1713+
const resolveTrees = queueToResolveTrees(legacy_queue);
1714+
legacy_queue.length = 0;
17151715
if (Date.now() - startTime > 500) {
17161716
this.warn(
17171717
'Timeout in the loop, please check the resolve tree data:',

0 commit comments

Comments
 (0)