diff --git a/.changeset/tender-jobs-itch.md b/.changeset/tender-jobs-itch.md new file mode 100644 index 00000000..512f89de --- /dev/null +++ b/.changeset/tender-jobs-itch.md @@ -0,0 +1,9 @@ +--- +"@snapwp/blocks": patch +"@snapwp/query": patch +"@snapwp/types": patch +"@snapwp/core": patch +"@snapwp/next": patch +--- + +refactor: Enforce `exactOptionalPropertyType` TypeScript rule diff --git a/config/tsconfig.base.json b/config/tsconfig.base.json index 676837b1..0b1a9664 100644 --- a/config/tsconfig.base.json +++ b/config/tsconfig.base.json @@ -7,7 +7,7 @@ "allowSyntheticDefaultImports": true, "allowUnreachableCode": false, "allowUnusedLabels": false, - "exactOptionalPropertyTypes": false, // @todo Enable this. + "exactOptionalPropertyTypes": true, "noFallthroughCasesInSwitch": true, "noImplicitOverride": true, "noImplicitReturns": true, diff --git a/packages/blocks/src/block-manager/index.tsx b/packages/blocks/src/block-manager/index.tsx index ec9392aa..ef075191 100644 --- a/packages/blocks/src/block-manager/index.tsx +++ b/packages/blocks/src/block-manager/index.tsx @@ -27,8 +27,12 @@ export default class BlockManager { * @return A tree of blocks. */ public static flatListToHierarchical( - blockList?: BlockData[] | null + blockList?: BlockData[] | null | undefined ): BlockTreeNode[] { + if ( ! blockList ) { + return []; + } + return flatListToHierarchical( blockList as unknown as Record< string | number, unknown >[], { @@ -75,10 +79,18 @@ export default class BlockManager { * @return A tree of blocks with render functions. */ public static parseBlockForRendering( - blockList?: BlockData[] | null + blockList?: BlockData[] | null | undefined ): BlockTreeNode[] { + if ( ! blockList ) { + return []; + } + const BlockTreeNodeArray = this.flatListToHierarchical( blockList ); + if ( ! BlockTreeNodeArray ) { + return []; + } + BlockTreeNodeArray.forEach( this.attachRendererToTreeNode ); return BlockTreeNodeArray; diff --git a/packages/blocks/src/blocks/core-audio.tsx b/packages/blocks/src/blocks/core-audio.tsx index 9c53853f..1e0a3e7a 100644 --- a/packages/blocks/src/blocks/core-audio.tsx +++ b/packages/blocks/src/blocks/core-audio.tsx @@ -36,7 +36,10 @@ const CoreAudio: CoreAudioType = ( { const classNames = cn( classNamesFromString ); return ( -
+