Skip to content

Commit 59ff0e1

Browse files
committedJun 27, 2017
fixed codeclimate issues
1 parent 23f62a5 commit 59ff0e1

File tree

7 files changed

+29
-28
lines changed

7 files changed

+29
-28
lines changed
 

‎.vscode/settings.json

+8-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,11 @@
11
{
22
"eslint.enable": true,
3-
"eslint.options": { "configFile": "./.eslintrc.yml" }
3+
"eslint.options": { "configFile": "./.eslintrc.yml" },
4+
"search.exclude": {
5+
"**/.git": true,
6+
"**/node_modules": true,
7+
"**/bower_components": true,
8+
"**/tmp": true,
9+
"**/lib": true
10+
}
411
}

‎lib/typed.js

+1-5
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ return /******/ (function(modules) { // webpackBootstrap
9797
if (this.bindInputFocusEvents) this.bindFocusEvents();
9898
self.timeout = setTimeout(function () {
9999
// Check if there is some text in the element, if yes start by backspacing the default message
100-
if (!self.currentElContent || self.currentElContent.length == 0) {
100+
if (!self.currentElContent || self.currentElContent.length === 0) {
101101
self.typewrite(self.strings[self.sequence[self.arrayPos]], self.strPos);
102102
} else {
103103
// Start typing
@@ -682,15 +682,13 @@ return /******/ (function(modules) { // webpackBootstrap
682682
// skip over html tags while typing
683683
var curChar = curString.substr(curStrPos).charAt(0);
684684
if (curChar === '<' || curChar === '&') {
685-
var tag = '';
686685
var endTag = '';
687686
if (curChar === '<') {
688687
endTag = '>';
689688
} else {
690689
endTag = ';';
691690
}
692691
while (curString.substr(curStrPos + 1).charAt(0) !== endTag) {
693-
tag += curChar;
694692
curStrPos++;
695693
if (curStrPos + 1 > curString.length) {
696694
break;
@@ -707,15 +705,13 @@ return /******/ (function(modules) { // webpackBootstrap
707705
var curChar = curString.substr(curStrPos).charAt(0);
708706
// skip over html tags while backspacing
709707
if (curChar === '>' || curChar === ';') {
710-
var tag = '';
711708
var endTag = '';
712709
if (curChar === '>') {
713710
endTag = '<';
714711
} else {
715712
endTag = '&';
716713
}
717714
while (curString.substr(curStrPos - 1).charAt(0) !== endTag) {
718-
tag -= curChar;
719715
curStrPos--;
720716
if (curStrPos < 0) {
721717
break;

‎lib/typed.min.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎lib/typed.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/html-parser.js

+6-8
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
11
export default class HTMLParser {
2-
32
typeHtmlChars(curString, curStrPos, self) {
43
if (self.contentType !== 'html') return curStrPos;
54
// skip over html tags while typing
65
const curChar = curString.substr(curStrPos).charAt(0);
76
if (curChar === '<' || curChar === '&') {
8-
let tag = '';
97
let endTag = '';
108
if (curChar === '<') {
119
endTag = '>'
@@ -14,9 +12,10 @@ export default class HTMLParser {
1412
endTag = ';'
1513
}
1614
while (curString.substr(curStrPos + 1).charAt(0) !== endTag) {
17-
tag += curChar;
1815
curStrPos++;
19-
if (curStrPos + 1 > curString.length) { break; }
16+
if (curStrPos + 1 > curString.length) {
17+
break;
18+
}
2019
}
2120
curStrPos++;
2221
}
@@ -28,7 +27,6 @@ export default class HTMLParser {
2827
const curChar = curString.substr(curStrPos).charAt(0);
2928
// skip over html tags while backspacing
3029
if (curChar === '>' || curChar === ';') {
31-
let tag = '';
3230
let endTag = '';
3331
if (curChar === '>') {
3432
endTag = '<'
@@ -37,15 +35,15 @@ export default class HTMLParser {
3735
endTag = '&'
3836
}
3937
while (curString.substr(curStrPos - 1).charAt(0) !== endTag) {
40-
tag -= curChar;
4138
curStrPos--;
42-
if (curStrPos < 0) { break; }
39+
if (curStrPos < 0) {
40+
break;
41+
}
4342
}
4443
curStrPos--;
4544
}
4645
return curStrPos;
4746
}
48-
4947
}
5048

5149
export let htmlParser = new HTMLParser();

‎src/typed.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export default class Typed {
1717
if (this.bindInputFocusEvents) this.bindFocusEvents();
1818
self.timeout = setTimeout(() => {
1919
// Check if there is some text in the element, if yes start by backspacing the default message
20-
if (!self.currentElContent || self.currentElContent.length == 0) {
20+
if (!self.currentElContent || self.currentElContent.length === 0) {
2121
self.typewrite(self.strings[self.sequence[self.arrayPos]], self.strPos);
2222
}
2323
else {

‎webpack.config.js

+11-11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import webpack from "webpack";
2-
import pkg from "./package.json";
1+
import webpack from 'webpack';
2+
import pkg from './package.json';
33
var banner = `
44
${pkg.name} - ${pkg.description}
55
Author: ${pkg.author}
@@ -10,22 +10,22 @@ var banner = `
1010

1111
export default {
1212
entry: {
13-
Typed: "./src/typed.js"
13+
Typed: './src/typed.js'
1414
},
1515
output: {
1616
path: __dirname,
1717
library: 'Typed',
18-
libraryTarget: "umd",
18+
libraryTarget: 'umd',
1919
filename: `typed.js`
2020
},
21-
devtool: "#inline-source-map",
21+
devtool: '#inline-source-map',
2222
externals: [
2323
{
2424
lodash: {
25-
root: "_",
26-
commonjs: "lodash",
27-
commonjs2: "lodash",
28-
amd: "lodash"
25+
root: '_',
26+
commonjs: 'lodash',
27+
commonjs2: 'lodash',
28+
amd: 'lodash'
2929
}
3030
}
3131
],
@@ -34,14 +34,14 @@ export default {
3434
{
3535
test: /\.js$/,
3636
exclude: /node_modules/,
37-
loader: "babel",
37+
loader: 'babel',
3838
query: {
3939
compact: false
4040
}
4141
}
4242
]
4343
},
4444
plugins: [
45-
new webpack.BannerPlugin( banner )
45+
new webpack.BannerPlugin(banner)
4646
]
4747
};

0 commit comments

Comments
 (0)