Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "no newline at end of file" warning #157

Open
dverbru opened this issue Dec 18, 2017 · 1 comment
Open

Show "no newline at end of file" warning #157

dverbru opened this issue Dec 18, 2017 · 1 comment

Comments

@dverbru
Copy link

dverbru commented Dec 18, 2017

Show "no newline at end of file" warning like in GitHub.


Step 1: Describe the problem:

Often text editors add new lines at EOF to comply with UNIX standard as git expects. When such newlines are introduced (or accidentally removed) to an already tracked file, this diff viewer doesn't offer a visual clue about that missing invisible character. Please note that git-diff shows a warning for this case in the terminal and GitHub supports it on their diff viewer.

Steps to reproduce:

  1. Create a text file that does not end with a new line character and commit it.
  2. Add a new line at the end of that file and commit it.
  3. Perform the diff with diff2html CLI.

Observed Results:

  • The last line is correctly marked as changed, but it is not visible what exactly changed in there.

Expected Results:

  • A "no newline at end of file" mark next the version missing it, like the one GitHub shows on their diff viewer.
@rtfpessoa
Copy link
Owner

@dverbru that makes complete sense. PRs are welcome 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants