Skip to content

Commit 13c8a42

Browse files
committed
Use toolbox when make rpm-release
1 parent 789895c commit 13c8a42

3 files changed

Lines changed: 19 additions & 9 deletions

File tree

.goreleaser.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,8 @@ nfpms:
126126
package_name: whereami
127127
file_name_template: >-
128128
{{ .PackageName }}-
129-
{{- .Version }}-
129+
{{- .Version }}-1.fc
130+
{{- if .Env.FEDORA_VERSION }}{{ .Env.FEDORA_VERSION }}{{ else }}42{{ end }}.
130131
{{- if eq .Arch "amd64" }}x86_64
131132
{{- else if eq .Arch "386" }}i386
132133
{{- else }}{{ .Arch }}{{ end }}

Makefile

Lines changed: 15 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -268,9 +268,15 @@ release-snapshot: check-release-deps
268268
goreleaser release --snapshot --clean
269269

270270
# Build RPMs using the generic configuration
271-
release-rpm: check-release-deps
272-
@echo "==> Building RPMs with GoReleaser"
273-
goreleaser release --config .goreleaser.yml --snapshot --clean
271+
release-rpm:
272+
@echo "==> Building RPMs with build-toolbox.sh"
273+
@if [ ! -x scripts/build-toolbox.sh ]; then \
274+
echo "Error: scripts/build-toolbox.sh not found or not executable"; \
275+
exit 1; \
276+
fi
277+
./scripts/build-toolbox.sh
278+
279+
274280

275281
# Create a full release (requires git tag)
276282
release: check-release-deps
@@ -305,9 +311,10 @@ help:
305311
@echo " flatpak-run Run installed Flatpak"
306312
@echo " flatpak-clean Remove Flatpak build dirs"
307313
@echo " flatpak-rebuild Clean + build + install"
314+
@echo " flatpak-bundle Create distributable .flatpak file"
315+
@echo " flatpak-release Upload .flatpak to latest GitHub release"
308316
@echo " release-snapshot Build snapshot release with GoReleaser"
309-
@echo " release-rpm Build generic RPMs with GoReleaser"
310-
@echo " release-rpm-fedora Build Fedora-specific RPMs"
317+
@echo " release-rpm Build RPMs using build-toolbox.sh"
311318
@echo " release Create full release (requires git tag)"
312319
@echo " print-vars Show variable values"
313320
@echo " help This message"
@@ -325,7 +332,9 @@ help:
325332
@echo ""
326333
@echo "Release examples:"
327334
@echo " make release-snapshot # Test build without publishing"
328-
@echo " make release-rpm # Build RPMs for distribution"
335+
@echo " make release-rpm # Build RPMs in Fedora toolbox"
336+
@echo " make flatpak-bundle # Create .flatpak file"
337+
@echo " make flatpak-release # Upload .flatpak to GitHub"
329338
@echo " git tag -a v1.0.0 -m 'Release v1.0.0'"
330339
@echo " make release # Create GitHub release"
331340
@echo ""

scripts/build-toolbox.sh

100644100755
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -253,7 +253,7 @@ DEPS_EOF
253253

254254
# Function to run the build
255255
run_build() {
256-
print_info "Running make release-rpm in toolbox..."
256+
print_info "Running goreleaser in toolbox..."
257257

258258
# Check if project is under home directory
259259
if [[ "$PROJECT_ROOT" != "$HOME"* ]]; then
@@ -263,7 +263,7 @@ run_build() {
263263

264264
# Run build in toolbox (home directory is automatically mounted)
265265
if ! toolbox run --container "$TOOLBOX_NAME" \
266-
bash -c "cd '$PROJECT_ROOT' && source ~/.bashrc && make release-rpm"; then
266+
bash -c "cd '$PROJECT_ROOT' && source ~/.bashrc && FEDORA_VERSION=\$(rpm -E %fedora) goreleaser release --config .goreleaser.yml --snapshot --clean"; then
267267
print_error "Build failed in toolbox"
268268
exit 1
269269
fi

0 commit comments

Comments
 (0)