Having no S3 object is not an irregular

Author: amatsuda

app/models/message.rb

@@ -92,7 +92,12 @@ def from_mail(mail, list, list_seq)
 
   class << self
     def from_s3(list, list_seq, s3_client = Aws::S3::Client.new(region: BLADE_BUCKET_REGION))
-      obj = s3_client.get_object(bucket: BLADE_BUCKET_NAME, key: "#{list.name}/#{list_seq}")
+      begin
+        obj = s3_client.get_object(bucket: BLADE_BUCKET_NAME, key: "#{list.name}/#{list_seq}")
+      rescue Aws::S3::Errors::NoSuchKey
+        p "#{list.name}:#{seq} doesn't exist in S3"
+        return
+      end
       str = obj.body.read.force_encoding(Encoding::BINARY)
       if str.blank?
         p "#{list.name}:#{list_seq} is empty"

bin/import_mails

@@ -42,8 +42,6 @@ Message.transaction do
       message.save!
     rescue ActiveRecord::RecordNotUnique
       STDERR.puts("#{list.name}:#{seq} already exists in Postgres")
-    rescue Aws::S3::Errors::NoSuchKey
-      STDERR.puts("#{list.name}:#{seq} doesn't exist in S3")
     rescue StandardError => e
       errors << [seq, e]
       STDERR.puts("failed to import #{list.name}:#{seq}: #{e}")