Fix specs for Env#keys and Env#each_key on Windows

Author: andrykonchin

core/env/each_key_spec.rb

@@ -1,6 +1,5 @@
 require_relative '../../spec_helper'
 require_relative '../enumerable/shared/enumeratorized'
-require_relative 'fixtures/common'
 
 describe "ENV.each_key" do
 
@@ -25,9 +24,30 @@
     enum.to_a.should == ENV.keys
   end
 
-  it "returns keys in the locale encoding" do
-    ENV.each_key do |key|
-      key.encoding.should == ENVSpecs.encoding
+  platform_is_not :windows do
+    it "returns keys in the locale encoding" do
+      ENV.each_key do |key|
+        key.encoding.should == Encoding.find('locale')
+      end
+    end
+  end
+
+  # https://bugs.ruby-lang.org/issues/20958
+  platform_is :windows do
+    ruby_version_is ""..."4.1" do
+      it "returns keys in the locale encoding" do
+        ENV.each_key do |key|
+          key.encoding.should == Encoding.find('locale')
+        end
+      end
+    end
+
+    ruby_version_is "4.1" do
+      it "returns the keys in UTF-8" do
+        ENV.each_key do |key|
+          key.encoding.should == Encoding::UTF_8
+        end
+      end
     end
   end
 

core/env/fixtures/common.rb

@@ -1,9 +1,7 @@
 module ENVSpecs
   def self.encoding
-    locale = Encoding.find('locale')
-    if ruby_version_is '3' and platform_is :windows
-      locale = Encoding::UTF_8
-    end
-    locale
+    return Encoding::UTF_8 if platform_is :windows
+
+    Encoding.find('locale')
   end
 end

core/env/keys_spec.rb

@@ -1,15 +1,35 @@
 require_relative '../../spec_helper'
-require_relative 'fixtures/common'
 
 describe "ENV.keys" do
 
   it "returns an array of the keys" do
     ENV.keys.should == ENV.to_hash.keys
   end
 
-  it "returns the keys in the locale encoding" do
-    ENV.keys.each do |key|
-      key.encoding.should == ENVSpecs.encoding
+  platform_is_not :windows do
+    it "returns the keys in the locale encoding" do
+      ENV.keys.each do |key|
+        key.encoding.should == Encoding.find('locale')
+      end
+    end
+  end
+
+  # https://bugs.ruby-lang.org/issues/20958
+  platform_is :windows do
+    ruby_version_is ""..."4.1" do
+      it "returns the keys in the locale encoding" do
+        ENV.keys.each do |key|
+          key.encoding.should == Encoding.find('locale')
+        end
+      end
+    end
+
+    ruby_version_is "4.1" do
+      it "returns the keys in UTF-8" do
+        ENV.keys.each do |key|
+          key.encoding.should == Encoding::UTF_8
+        end
+      end
     end
   end
 end