Support for headless=new (#379)

* feat: Support for headless=new

* chore: comments

* fix: linux position spec

* fix: README.md

Author: route

README.md

@@ -145,7 +145,8 @@ Ferrum::Browser.new(options)
 ```
 
 * options `Hash`
-  * `:headless` (Boolean) - Set browser as headless or not, `true` by default.
+  * `:headless` (String | Boolean) - Set browser as headless or not, `true` by default. You can set `"new"` to support
+      [new headless mode](https://developer.chrome.com/articles/new-headless/).
   * `:xvfb` (Boolean) - Run browser in a virtual framebuffer, `false` by default.
   * `:window_size` (Array) - The dimensions of the browser window in which to
       test, expressed as a 2-element array, e.g. [1024, 768]. Default: [1024, 768]

lib/ferrum/browser.rb

@@ -264,6 +264,10 @@ def version
       VersionInfo.new(command("Browser.getVersion"))
     end
 
+    def headless_new?
+      process&.command&.headless_new?
+    end
+
     private
 
     def start

lib/ferrum/browser/client.rb

@@ -84,7 +84,8 @@ def raise_browser_error(error)
         case error["message"]
         # Node has disappeared while we were trying to get it
         when "No node with given id found",
-             "Could not find node with given id"
+             "Could not find node with given id",
+             "Inspected target navigated or closed"
           raise NodeNotFoundError, error
         # Context is lost, page is reloading
         when "Cannot find context with specified id"

lib/ferrum/browser/command.rb

@@ -39,6 +39,10 @@ def xvfb?
         !!options.xvfb
       end
 
+      def headless_new?
+        @flags["headless"] == "new"
+      end
+
       def to_a
         [path] + @flags.map { |k, v| v.nil? ? "--#{k}" : "--#{k}=#{v}" }
       end

lib/ferrum/browser/options/chrome.rb

@@ -19,8 +19,9 @@ class Chrome < Base
           "keep-alive-for-test" => nil,
           "disable-popup-blocking" => nil,
           "disable-extensions" => nil,
+          "disable-component-extensions-with-background-pages" => nil,
           "disable-hang-monitor" => nil,
-          "disable-features" => "site-per-process,TranslateUI",
+          "disable-features" => "site-per-process,IsolateOrigins,TranslateUI",
           "disable-translate" => nil,
           "disable-background-networking" => nil,
           "enable-features" => "NetworkService,NetworkServiceInProcess",
@@ -32,6 +33,7 @@ class Chrome < Base
           "disable-ipc-flooding-protection" => nil,
           "disable-prompt-on-repost" => nil,
           "disable-renderer-backgrounding" => nil,
+          "disable-site-isolation-trials" => nil,
           "force-color-profile" => "srgb",
           "metrics-recording-only" => nil,
           "safebrowsing-disable-auto-update" => nil,
@@ -74,7 +76,12 @@ def merge_required(flags, options, user_data_dir)
         end
 
         def merge_default(flags, options)
-          defaults = except("headless", "disable-gpu") unless options.headless
+          defaults = case options.headless
+                     when false
+                       except("headless", "disable-gpu")
+                     when "new"
+                       except("headless").merge("headless" => "new")
+                     end
 
           defaults ||= DEFAULT_OPTIONS
           defaults.merge(flags)

lib/ferrum/page.rb

@@ -390,7 +390,8 @@ def prepare_page
       resize(width: width, height: height)
 
       response = command("Page.getNavigationHistory")
-      return unless response.dig("entries", 0, "transitionType") != "typed"
+      transition_type = response.dig("entries", 0, "transitionType")
+      return if transition_type == "auto_toplevel"
 
       # If we create page by clicking links, submitting forms and so on it
       # opens a new window for which `frameStoppedLoading` event never

spec/browser_spec.rb

@@ -181,7 +181,15 @@
             proxy: { host: proxy.host, port: proxy.port, user: "u1", password: "p1" }
           )
 
-          browser.go_to("https://example.com")
+          if browser.headless_new?
+            expect { browser.go_to("https://example.com") }.to raise_error(
+              Ferrum::StatusError,
+              "Request to https://example.com failed (net::ERR_HTTP_RESPONSE_CODE_FAILURE)"
+            )
+          else
+            browser.go_to("https://example.com")
+          end
+
           expect(browser.network.status).to eq(407)
         ensure
           browser&.quit
@@ -234,6 +242,9 @@
         let(:save_path) { "/tmp/ferrum" }
 
         it "saves an attachment" do
+          # Also https://github.com/puppeteer/puppeteer/issues/10161
+          skip "https://bugs.chromium.org/p/chromium/issues/detail?id=1444729" if browser.headless_new?
+
           browser.go_to("/#{filename}")
 
           expect(File.exist?("#{save_path}/#{filename}")).to be true
@@ -531,7 +542,15 @@
         it "fails with wrong password" do
           page = browser.create_page(proxy: { host: proxy.host, port: proxy.port,
                                               user: options[:user], password: "$$" })
-          page.go_to("https://example.com")
+
+          if browser.headless_new?
+            expect { page.go_to("https://example.com") }.to raise_error(
+              Ferrum::StatusError,
+              "Request to https://example.com failed (net::ERR_HTTP_RESPONSE_CODE_FAILURE)"
+            )
+          else
+            page.go_to("https://example.com")
+          end
 
           expect(page.network.status).to eq(407)
         end