Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Back and Forth Buttons to Case Contact Form #5777

Open
bcastillo32 opened this issue May 27, 2024 · 16 comments · May be fixed by #5923
Open

Add Back and Forth Buttons to Case Contact Form #5777

bcastillo32 opened this issue May 27, 2024 · 16 comments · May be fixed by #5923
Labels
Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge

Comments

@bcastillo32
Copy link
Collaborator

bcastillo32 commented May 27, 2024

What type(s) of user does this feature affect?

  • volunteers
  • supervisors
  • admins

Description

Please add simple back and forth buttons to the case contact form - can be simple buttons with "<" and ">" like seen on the carousels here. Please place them to the left of "Step" on each page. If you move from page to page, any changes made should be saved.

image

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

@elasticspoon elasticspoon added Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge and removed Ruby for Good 2024 DC labels May 29, 2024
@priyapower
Copy link

priyapower commented Jun 12, 2024

👋🏾 Happy to take this on

The slack link doesn't look like a live link anymore - but will also plan to attend office hours next Tuesday via discord

Looking for advice on what is preferred?

  • Option 1: using the experimental codespace method
  • Option 2: fork repo
  • Option 3: clone repo (I will need to ask a maintainer to give me branch creation perms)

@elasticspoon
Copy link
Collaborator

This should be a working link https://join.slack.com/t/rubyforgood/shared_invite/zt-2k5ezv241-Ia2Iac3amxDS8CuhOr69ZA.

Up to you in terms of what method you prefer. Fork vs get perms but in most open source projects you will be forking so I would suggest that.

I would also suggest the local install instead of code spaces just cause those are capped at 60hours free a month.

@priyapower
Copy link

This should be a working link https://join.slack.com/t/rubyforgood/shared_invite/zt-2k5ezv241-Ia2Iac3amxDS8CuhOr69ZA.

Up to you in terms of what method you prefer. Fork vs get perms but in most open source projects you will be forking so I would suggest that.

I would also suggest the local install instead of code spaces just cause those are capped at 60hours free a month.

@elasticspoon - thank you for the suggestions - I am happy to fork and I have done a local install and thank you for the updated slack link!

Copy link

This issue has been inactive for 243 hours (10.13 days) and will be unassigned after 117 more hours (4.88 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Copy link

This issue has been inactive for 363 hours (15.13 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

@priyapower
Copy link

Commenting for more time

Copy link

This issue has been inactive for 263 hours (10.96 days) and will be unassigned after 97 more hours (4.04 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

@priyapower
Copy link

priyapower commented Jul 15, 2024

I was ghastly ill and bedridden for a couple weeks - I am official better now and can work on this; however, also happy to hand off. Sorry for lack of communication, I was unable to handle even getting onto a computer

EDIT: Made progress today, I have nav buttons, now working on conditions (disable back if no back, disable forward if no forward, etc) - aiming for an initial PR up by tomorrow EOD (CT)

@priyapower
Copy link

PR is currently in draft. Things to finish/update after power outage is resolved (Chicago hit with major storm):

  • 🐛 Back button validates but routes incorrectly after validation is successful
  • 🧪 Spec updates (thought I see some potential failing specs on main - this could be a local development issue though, so will capture more details)

priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 17, 2024
@priyapower
Copy link

Ready for review: #5923

@priyapower
Copy link

@elasticspoon - I realize that my PR was only marked ready for review like 12ish hours ago so I hope I'm not coming off as pushy, more curious about how y'all work - besides the automatic reviewers based on code owners, is there anything else I need to do to get a review?

(I checked the contribution guide and setup readme and I don't see anything about this but I could be missing it)

@elasticspoon
Copy link
Collaborator

@priyapower Nope! You are good. It usually takes a bit for a review. If there is no movement for like a 5+ days feel free to ask for a review in the casa slack.

We typically do reviews in batches 1-2 times a week. (I say we but everyone has their own patterns).

priyapower added a commit to priyapower/casa that referenced this issue Jul 22, 2024
priyapower added a commit to priyapower/casa that referenced this issue Jul 22, 2024
Copy link

This issue has been inactive for 249 hours (10.38 days) and will be unassigned after 111 more hours (4.63 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Copy link

github-actions bot commented Aug 4, 2024

This issue has been inactive for 369 hours (15.38 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

Copy link

github-actions bot commented Oct 4, 2024

This issue has been open without changes for a long time! What's up?

@thejonroberts
Copy link
Contributor

Resolved in #6048 - single page form

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Intermediate Spans multiple domains or requires more advanced coding knowledge
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants