Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added table name and styling to volunteers without supervisors table #6037

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Added table name and styling to volunteers without supervisors table #6037

merged 2 commits into from
Sep 20, 2024

Conversation

leevic31
Copy link
Contributor

What github issue is this PR for, if any?

Resolves #6025

What changed, and why?

Added a table name to the table that shows active volunteers without supervisors. The title is Volunteers without Supervisors. Changed the styling of this table to match the other tables in the supervisors page.

Screenshots please :)

Screenshot from 2024-09-09 20-57-26

@github-actions github-actions bot added the erb label Sep 10, 2024
elasticspoon
elasticspoon approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@elasticspoon elasticspoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment but looks good besides that. Thank you!

app/views/supervisors/index.html.erb Outdated Show resolved Hide resolved
@compwron
Copy link
Collaborator

CI says

     # --- Caused by: ---
     # Capybara::ElementNotFound:
     #   Unable to find checkbox "user_receive_sms_notifications" that is not disabled
     #   ./spec/system/users/edit_spec.rb:211:in `block (3 levels) in <top (required)>'

Finished in 6 minutes 28 seconds (files took 8.63 seconds to load)
2979 examples, 1 failure, 5 pending

Failed examples:

rspec ./spec/system/users/edit_spec.rb:199 # users/edit volunteer user displays notification events selection as disabled if sms notification preference is not selected

Unclear to me whether it's a flake or a valid failure

@elasticspoon
Copy link
Collaborator

Runs locally for me, I am willing to call it a flake

@elasticspoon elasticspoon merged commit c6f032a into rubyforgood:main Sep 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haiderRizvii haiderRizvii haiderRizvii approved these changes

@elasticspoon elasticspoon elasticspoon approved these changes

@compwron compwron Awaiting requested review from compwron compwron is a code owner

@FireLemons FireLemons Awaiting requested review from FireLemons FireLemons is a code owner

Assignees
No one assigned
Labels
erb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

active volunteers without supervisors is missing table styling
4 participants
@leevic31 @compwron @elasticspoon @haiderRizvii