Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve timezones on sent emails page on org settings as admin #6026

Closed
elasticspoon opened this issue Sep 7, 2024 · 6 comments · Fixed by #6043
Closed

Improve timezones on sent emails page on org settings as admin #6026

elasticspoon opened this issue Sep 7, 2024 · 6 comments · Fixed by #6043
Assignees
Labels
Difficulty: Easy Spans a single domain without much coding knowledge needed

Comments

@elasticspoon
Copy link
Collaborator

What type(s) of user does this feature affect?

  • admins

Description

Under /casa_org/:id/edit we have a table that shows all sent emails.

Image

The times on this table are all in UTC. The Admins would love it if you could change it to use a more reasonable timezone.

I believe there are a few helpers in the application that set the timezone and it should be getting set as a session token as well.

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

@elasticspoon elasticspoon added Difficulty: Easy Spans a single domain without much coding knowledge needed Help Wanted This is a special label that enables github to showcase issues that want help labels Sep 7, 2024
@panacotar
Copy link
Contributor

Hi, I can maybe look into it.
But about "a more reasonable timezone", does that mean the user's local timezone?
For this, I found the User::TimeZone concern, which reads the :browser_time_zone cookie. I think this might work.

@elasticspoon
Copy link
Collaborator Author

@dariuspirvulescu yea that exactly what we are going for. And if that can't be found EST is a reasonable fallback (most of our users in in the DC area)

@github-actions github-actions bot removed the Help Wanted This is a special label that enables github to showcase issues that want help label Sep 14, 2024
Copy link

This issue has been inactive for 243 hours (10.13 days) and will be unassigned after 117 more hours (4.88 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

@panacotar
Copy link
Contributor

Still working on it.

Copy link

github-actions bot commented Oct 7, 2024

This issue has been inactive for 262 hours (10.92 days) and will be unassigned after 98 more hours (4.08 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

@panacotar
Copy link
Contributor

PR open and ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Easy Spans a single domain without much coding knowledge needed
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants