Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default the quantity per individual to 50 in the data, except for kits, which should be 1. #5037

Open
2 tasks
cielf opened this issue Feb 23, 2025 · 4 comments · May be fixed by #5080
Open
2 tasks

Default the quantity per individual to 50 in the data, except for kits, which should be 1. #5037

cielf opened this issue Feb 23, 2025 · 4 comments · May be fixed by #5080
Assignees

Comments

@cielf
Copy link
Collaborator

cielf commented Feb 23, 2025

Summary

Default the quantity per individual for items to 50 in the data, except for kits, which should be 1

Why?

The blank quantity is resulting in some follow-on issues, also making it explicit to the banks that this is what we use.

Details

1/ When creating a new item through the interface, the value for quantity per individual is defaulted to 50
2/ When we create a kit, that value on the accompanying item (the one that represents the kit) is defaulted to 1
3/ Migration to set blank quantities per individual on items to 50, unless the item represents a kit, in which case a blank quantity will be set to 1.

Criteria for completion

  • behaviour as described above
  • automated tests supporting the above behaviour

Note

Feedback from 20250108 stakeholders meeting. No issues with the concept - go ahead.

@cielf cielf added Help Wanted Groomed + open to all! Difficulty—Beginner labels Feb 23, 2025
@nathangthomas
Copy link
Contributor

Hi there @cielf Can I take this ticket?

@cielf
Copy link
Collaborator Author

cielf commented Feb 28, 2025

Please do!

@github-actions github-actions bot removed the Help Wanted Groomed + open to all! label Feb 28, 2025
@nathangthomas
Copy link
Contributor

@cielf should items that currently have a nil distribution_quantity be updated or would you like them to remain as they are?

@cielf
Copy link
Collaborator Author

cielf commented Mar 3, 2025

@nathangthomas Update them, please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants