-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inactivating vendors #4949
Comments
Hey @cielf, I’d like to take on this feature. Regarding the edge case (a vendor having had purchases that were later deleted), should I focus on implementing the inactivation functionality first, and defer the full delete feature for a later phase? |
If you want to break it into two PRs, that's great. Note on the PR that it's a partial fix. |
Hey @cielf sorry to bother you, but can you look at the PR when you have time? |
Yup. It's on my list already. We're all volunteers here, so it can take days. |
This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned. |
This is in the review process. |
Summary
Provide the ability to deactivate (and restore) vendors
Why?
Some of our banks have been using the system for over 5 years. Over time, vendors go out of business, and it would be nice to be able to hide the defunct ones. Reduce new bank staff error.
Details
We already provide deactivation/reactivation for many of our models. See Item as a model.
Provide the ability, for bank admin access only, to deactivate vendors.
This will be on the Community | Vendors page
If the vendor has no purchases associated with it (for discussion: edge case - someone enters a purchase with the vendor, then deletes it. Would that be a problem) and never has, allow to have the vendor deleted instead.
When a user selects deactivation or deletion, they must confirm their choice.
When vendor is deactivated, it doesn't appear in the vendor drop-down in new/edit purchase.
Add a "include inactive" filter for vendors. There is currently no filter on the vendors page, so you'll need to build that in, following the pattern on Items.
if a vendor is inactive, provide a "restore" button beside it in the vendor index. Pushing this invokes a confirmation window, then on user assent, sets the status of the vendor back to active.
You'll need a migration too, the default setting for the active flag will be true.
Priority
Per stakeholders, not high priority, but would be nice for keeping things tidy
Criteria for completion
The text was updated successfully, but these errors were encountered: