Merge pull request #43 from mlarraz/type_fix

Return same type after rescuing parser error
rubygems · Apr 21, 2018 · 040b247 · 040b247
2 parents 577b04c + 221bb88
commit 040b247
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Gemfile b/Gemfile
@@ -12,7 +12,7 @@ group :test do
   gem 'backports'
   gem 'coveralls'
   gem 'rspec', '>= 3.1.0'
-  gem 'rubocop', '>= 0.50'
+  gem 'rubocop', '~> 0.52.1'
   gem 'simplecov', '>= 0.9'
   gem 'webmock'
   gem 'yardstick'

diff --git a/lib/gems/client.rb b/lib/gems/client.rb
@@ -26,7 +26,7 @@ def info(gem_name)
       response = get("/api/v1/gems/#{gem_name}.json")
       JSON.parse(response)
     rescue JSON::ParserError
-      []
+      {}
     end
 
     # Returns an array of active gems that match the query

diff --git a/spec/gems/client_spec.rb b/spec/gems/client_spec.rb
@@ -26,7 +26,7 @@
       it 'returns some basic information about the given gem' do
         info = Gems.info 'nonexistentgem'
         expect(a_get('/api/v1/gems/nonexistentgem.json')).to have_been_made
-        expect(info).to eq []
+        expect(info['name']).to be_nil
       end
     end
   end