Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalInterface call open popUp freezes #19507

Open
beckmx opened this issue Feb 12, 2025 · 1 comment
Open

ExternalInterface call open popUp freezes #19507

beckmx opened this issue Feb 12, 2025 · 1 comment
Labels
bug Something isn't working panic Hit a panic

Comments

@beckmx
Copy link

beckmx commented Feb 12, 2025

Describe what you were doing

Hello there, I have been trying to revive an old tool i have for cnc machines, I added (in the old days) a button to open a popup and it does open the popup, but the "ruffle" freezes or stops responding, the code itself in AS3 is this:

private function open3dModel(evt:MouseEvent):void{

		if(currentFile==null){
			startDialog(350, 50, new Array({type:"label", label:languageDictionary.save3d}), "error");
			return;
		}
		ExternalInterface.call("open", "/files?viewer="+currentFile, "_blank", "width=700,height=600");
	}

What does the crash message say?

ruffle_web.js:1841 Uncaught RangeError: Maximum call stack size exceeded
at Function.entries ()
at n.wbg.__wbg_entries_3265d4158b33e5dc (ruffle_web.js:1841:28)
at ruffle_web.wasm.ruffle_web::external_interface::js_to_external_value::hd3b76e826dfc07e9 (ruffle_web.wasm-032b65c6:0x4c10c4)
at ruffle_web.wasm.ruffle_web::external_interface::js_to_external_value::hd3b76e826dfc07e9 (ruffle_web.wasm-032b65c6:0x4c11e4)
at ruffle_web.wasm.ruffle_web::external_interface::js_to_external_value::hd3b76e826dfc07e9 (ruffle_web.wasm-032b65c6:0x4c11e4)
at ruffle_web.wasm.ruffle_web::external_interface::js_to_external_value::hd3b76e826dfc07e9 (ruffle_web.wasm-032b65c6:0x4c11e4)
at ruffle_web.wasm.ruffle_web::external_interface::js_to_external_value::hd3b76e826dfc07e9 (ruffle_web.wasm-032b65c6:0x4c11e4)
at ruffle_web.wasm.ruffle_web::external_interface::js_to_external_value::hd3b76e826dfc07e9 (ruffle_web.wasm-032b65c6:0x4c11e4)
at ruffle_web.wasm.ruffle_web::external_interface::js_to_external_value::hd3b76e826dfc07e9 (ruffle_web.wasm-032b65c6:0x4c11e4)
at ruffle_web.wasm.ruffle_web::external_interface::js_to_external_value::hd3b76e826dfc07e9 (ruffle_web.wasm-032b65c6:0x4c11e4)
core.ruffle.69b04cc….js:1 [Violation] 'pointerup' handler took 453ms
ruffle_web.js:2565 ERROR web/src/lib.rs:948 Unable to borrow Ruffle instance
ruffle_web.js:2565 ERROR web/src/lib.rs:948 Unable to borrow Ruffle instance
ruffle_web.js:2565 ERROR web/src/lib.rs:1012 Unable to lock Ruffle core
32
ruffle_web.js:2565 ERROR web/src/lib.rs:1202 Unable to lock Ruffle core
ruffle_web.js:2565 ERROR web/src/lib.rs:1202 Unable to lock Ruffle core
ruffle_web.js:2565 ERROR web/src/lib.rs:1202 Unable to lock Ruffle core
4
ruffle_web.js:2565 ERROR web/src/lib.rs:1202 Unable to lock Ruffle core
ruffle_web.js:2565 ERROR web/src/lib.rs:1202 Unable to lock Ruffle core


Ruffle Version

Version: nightly 2025-02-12 | WebAssembly extensions: ON | Used renderer: wgpu-webgl)

Affected platform

Online demo

Operating system

Macos

Additional information

No response

@beckmx beckmx added bug Something isn't working panic Hit a panic labels Feb 12, 2025
@adrian17
Copy link
Collaborator

adrian17 commented Feb 14, 2025

Hmm, open() returns a Window, and we completely fail trying to serialize that back to AS objects (either because it's a super deep object, or because the object graph has a cycle, or both).
Will need to investigate whether Flash Player also tried to serialize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working panic Hit a panic
Projects
None yet
Development

No branches or pull requests

2 participants