fix: stepwise execution breaks when steps do async work #17914
+78
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
In stepwise execution, every call to
handler.run_step()
checks if the workflow is done or if the next step should be unblocked for execution. Before this PR, unless workflow is not done,run_step
assumes the previous step has returned, which is not true if the step itselfawait
s on something.Solution
With this PR, a new functionality was added to the
Context
to keep track of step functions that have been called and are mid-flight (i.e. they haven't returned yet). Using this feature,run_step
can now wait for a step to finish before moving on with the next step in line.Fixes #17898
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.