Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Command: atlantis lock #4877

Open
1 task done
hjkatz opened this issue Aug 28, 2024 · 0 comments
Open
1 task done

[feature] Command: atlantis lock #4877

hjkatz opened this issue Aug 28, 2024 · 0 comments
Labels
feature New functionality/enhancement

Comments

@hjkatz
Copy link

hjkatz commented Aug 28, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Describe the user story

See: #3879 (comment)

Copied Below:

So the use-case we have had in the past is via mode: on_plan.

  1. Make changes to many many AWS roots (we're about to perform an upgrade)
  2. auto-plan, atlantis takes the lock on the PR, now nobody can plan (nor apply) while we're upgrading
  3. We make manual TF changes locally and apply via terraform apply (not using atlantis apply), here we are relying on the atlantis PR lock as a communication tactic informing other users that they can't touch TF right now because we are doing things out-of-band
  4. We finish the TF changes, now we atlantis plan and confirm there are no changes
  5. We atlantis apply (no-op)
  6. We merge the PR, atlantis drops the lock, now users can plan/apply on their own PRs

To make a similar process with mode: on_apply we need a way to tell atlantis that other PRs are not allowed to apply any of the roots touched in our PR. Normally this would be coordinated via the atlantis lock (on_plan) on our PR, but since we're using on_apply that atlantis lock no longer exists.

We would ideally still want a way to "claim" the projects via an atlantis lock command, or atlantis apply --no-op or something....

Describe the solution you'd like

New Command: atlantis lock to complement atlantis unlock

This would lock the PR even during mode: on_apply for the project roots included in the PR

Describe the drawbacks of your solution

Describe alternatives you've considered

@hjkatz hjkatz added the feature New functionality/enhancement label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New functionality/enhancement
Projects
None yet
Development

No branches or pull requests

1 participant