-
Notifications
You must be signed in to change notification settings - Fork 8
WIP Localized Autocomplete #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rgbkrk
wants to merge
10
commits into
main
Choose a base branch
from
feature/pyodide-autocomplete
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add IPython-based completion support to Python runtime shell - Extend worker protocol with get_completions message handler - Add getCompletions method to PyodideRuntimeAgent - Create Python completion source for CodeMirror integration - Wire completion to ExecutableCell for code cells with Python runtime - Add comprehensive plan and TODO documentation Provides context-aware Python completions without LiveStore events, using direct worker communication for multi-user safe autocomplete.
- Add detailed console logging to track completion flow - Add visual debug indicator for completion source status - Add Tab key support for accepting completions - Improve completion keymap handling
- Add getCurrentPyodideAgent method to ConsoleLauncher - Expose method on global __RUNT_LAUNCHER__ interface - Update ExecutableCell to use proper public method - Should fix completion access to Pyodide runtime agent
- Add get_completions to runt_runtime.py imports and __all__ - Should make the function available in Python runtime global scope - Fixes NameError when trying to call get_completions from worker
- Add get_completions to globals() in setupIPythonEnvironment - Makes completion function available for worker execution - Should fix NameError when calling get_completions from worker
- Import json module and use json.dumps() to return JSON string - Matches pattern used by get_registered_tools() function - Should fix JSON parsing error in worker completion handler
- Improve cursor position parsing and line detection - Add execution context to IPython completer via shell.user_ns - Add fallback completion for Python builtins when IPython fails - Add comprehensive debug logging for troubleshooting - Should now provide basic completions for common Python functions
- Improve namespace sync between global and IPython shell - Add Jedi completion as fallback for module attributes - Add manual module attribute completion with namespace lookup - Add common module completions for math, numpy, pandas, etc. - Should now handle 'import math; math.' completion cases
- Allow CodeMirror completion after dot even with no partial text - Fix backend parsing for empty partial attributes - Add comprehensive debugging for completion request flow - Limit large attribute lists to first 20 items - Should fix 'math.' completion triggering
- Rename second beforeCursor to charBeforeCursor to avoid conflict - Fixes TypeScript compilation error
|
I merged a change that would allow us to bind shortcuts to the In short, the React wrapper for CodeMirror added extensions even when the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP