fix sa errors

Author: jrushlow

phpstan.dist.neon

@@ -7,4 +7,9 @@ parameters:
         containerXmlPath: var/cache/test/App_KernelTestDebugContainer.xml
     doctrine:
         ormRepositoryClass: App\Repository\AbstractRepository
-        objectManagerLoader: tests/phpstan-bootstrap.php
+        objectManagerLoader: tests/phpstan-bootstrap.php
+    ignoreErrors:
+        -
+            message: '#Variable \$[a-zA-Z0-9]+ might not be defined\.#'
+#            identifier: variable.undefined // Available in phpstan 1.11.0
+            path: src/GraphQLRequest/*

src/Factory/Model/GitHubPullRequestFactory.php

@@ -58,6 +58,7 @@ protected function getDefaults(): array
         ];
     }
 
+    /** @param GitHubUrlData|Proxy<GitHubUrlData> $urlData */
     public function fromUrlData(GitHubUrlData|Proxy $urlData, string $title = '[ci] run sa tools'): self
     {
         return $this->addState([

src/Factory/Model/GitHubUrlDataFactory.php

@@ -42,6 +42,7 @@
  */
 class GitHubUrlDataFactory extends ModelFactory
 {
+    /** @return array<string, string|int|TypeEnum> */
     #[\Override]
     protected function getDefaults(): array
     {
@@ -53,19 +54,20 @@ protected function getDefaults(): array
             'uri' => sprintf('https://github.com/%s/%s/%s/%s',
                 $owner,
                 $repository,
-                TypeEnum::PULL_REQUEST === $type ? 'pulls' : 'issues',
+                TypeEnum::PULL_REQUEST === $type ? 'pulls' : 'issues', // @phpstan-ignore-line
                 $id
             ),
         ];
     }
 
     public function asIssue(): self
     {
+        /** @var string $uri */
         $uri = $this->getDefaults()['uri'];
 
         return $this->addState([
             'type' => TypeEnum::ISSUE,
-            'uri' => str_replace(TypeEnum::PULL_REQUEST->value, TypeEnum::ISSUE->value, (string) $uri),
+            'uri' => str_replace(TypeEnum::PULL_REQUEST->value, TypeEnum::ISSUE->value, $uri),
         ]);
     }
 

src/Factory/TaskFactory.php

@@ -62,6 +62,7 @@ public function withName(string $name): self
         return $this->addState(['name' => $name]);
     }
 
+    /** @param TodoList|Proxy<TodoList> $todoList */
     public function forTodoList(TodoList|Proxy $todoList): self
     {
         return $this->addState(['todoList' => $todoList]);

src/Service/TaskService.php

@@ -32,6 +32,8 @@ public function __construct(
     }
 
     /**
+     * @param GitHubUrlData|GitHubUrlData[] $urlData
+     *
      * @return array<int, GitHubIssue|GitHubPullRequest>
      *
      * @throws HttpClientException
@@ -78,9 +80,9 @@ public function getGitHubDataFromUrl(GitHubUrlData|array $urlData, string $owner
                     return $match;
                 });
 
-                if (null === $result) {
-                    continue;
-                }
+                // if (null === $result) {
+                //     continue;
+                // }
 
                 $objects[] = new GitHubPullRequest(
                     uri: $result->uri,
@@ -99,9 +101,9 @@ public function getGitHubDataFromUrl(GitHubUrlData|array $urlData, string $owner
                     return $match;
                 });
 
-                if (null === $result) {
-                    continue;
-                }
+                // if (null === $result) {
+                //     continue;
+                // }
 
                 $objects[] = new GitHubIssue(
                     uri: $result->uri,
@@ -161,13 +163,23 @@ private function createQueryContent(array $urls): string
         ]);
     }
 
+    /**
+     * @param string               $templatePath The absolute path to the template with filename and extension
+     * @param array<string, mixed> $parameters   array of variables used in the template
+     *                                           where the "key" is the variable name and the "value" is the value of the variable
+     *                                           in the template
+     */
     private function getTemplate(string $templatePath, array $parameters): string
     {
         ob_start();
         extract($parameters, \EXTR_SKIP);
         include $templatePath;
 
-        return ob_get_clean();
+        if (false === $template = ob_get_clean()) {
+            throw new \RuntimeException('Ooops! somethign went wrong trying to generate the template.');
+        }
+
+        return $template;
     }
 
     /**

tests/Functional/Service/TaskServiceTest.php

@@ -20,9 +20,8 @@ final class TaskServiceTest extends FunctionalTestCase
 {
     private const string ISSUE_FRAGMENT = 'fragment issue on Issue';
     private const string PULL_FRAGMENT = 'fragment pr on PullRequest';
-
-    private Security|MockObject $mockSecurity;
-    private EncryptorService|MockObject $mockEncryptor;
+    private MockObject&Security $mockSecurity;
+    private EncryptorService&MockObject $mockEncryptor;
     private MockResponse $mockResponse;
 
     #[\Override]