Add support for bitcoin core 0.17.2

Author: GideonBature

.github/workflows/rust.yaml

@@ -224,7 +224,7 @@ jobs:
             "0_20_2",
             "0_19_1",
             "0_18_1",
-            "0_17_1",
+            "0_17_2",
           ]
     steps:
       - name: "Checkout repo"

client/src/client_sync/v17/mod.rs

@@ -26,7 +26,7 @@ use crate::types::v17::*;
 pub use crate::client_sync::WalletCreateFundedPsbtInput;
 
 crate::define_jsonrpc_minreq_client!("v17");
-crate::impl_client_check_expected_server_version!({ [170100] });
+crate::impl_client_check_expected_server_version!({ [170200] });
 
 // == Blockchain ==
 crate::impl_client_v17__getbestblockhash!();

integration_test/Cargo.toml

@@ -29,7 +29,7 @@ edition = "2021"
 0_20_2 = ["v20", "node/0_20_2"]
 0_19_1 = ["v19", "node/0_19_1"]
 0_18_1 = ["v18", "node/0_18_1"]
-0_17_1 = ["v17", "node/0_17_1"]
+0_17_2 = ["v17", "node/0_17_2"]
 
 # These features are just for internal use (feature gating).
 # Each major version is tested with the same client.

node/Cargo.toml

@@ -36,11 +36,11 @@ zip = { version = "0.5.13", optional = true }
 #
 # - `cargo test --features=27_2,download` to download Bitcoin Core binary `v27.2`.
 # - `cargo test --features=28_0` to use `bitcoind` from the host environment.
-# - `cargo test` is equivalent to `cargo test --features=0_17_1`.
+# - `cargo test` is equivalent to `cargo test --features=0_17_2`.
 # - `cargo test --all-features`: Same as using latest version.
 # - `cargo test --no-default-features` does not work, you MUST enable a version feature.
 [features]
-default = ["0_17_1"]
+default = ["0_17_2"]
 
 download = ["anyhow", "bitcoin_hashes", "flate2", "tar", "minreq", "zip"]
 
@@ -61,8 +61,8 @@ download = ["anyhow", "bitcoin_hashes", "flate2", "tar", "minreq", "zip"]
 0_21_2 = ["0_20_2"]
 0_20_2 = ["0_19_1"]
 0_19_1 = ["0_18_1"]
-0_18_1 = ["0_17_1"]
-0_17_1 = []
+0_18_1 = ["0_17_2"]
+0_17_2 = []
 
 [package.metadata.docs.rs]
 features = ["28_0"]

node/contrib/extra_tests.sh

@@ -15,7 +15,7 @@
 set -euox pipefail
 
 FEATURES=("28_0" "27_1" "27_0" "26_2" "26_1" "26_0" "25_2" "24_2"  \
-          "23_2" "22_1" "0_21_2" "0_20_2" "0_19_1" "0_18_1" "0_17_1")
+          "23_2" "22_1" "0_21_2" "0_20_2" "0_19_1" "0_18_1" "0_17_2")
 
 # Use the current `Cargo.lock` file without updating it.
 cargo="cargo --locked"

node/sha256/bitcoin-core-0.17.1-SHA256SUMS.asc

@@ -0,0 +1,29 @@
+-----BEGIN PGP SIGNED MESSAGE-----
+Hash: SHA256
+
+5a6b35d1a348a402f2d2d6ab5aed653a1a1f13bc63aaaf51605e3501b0733b7a  bitcoin-0.17.2-aarch64-linux-gnu.tar.gz
+d1913a5d19c8e8da4a67d1bd5205d03c8614dfd2e02bba2fe3087476643a729e  bitcoin-0.17.2-arm-linux-gnueabihf.tar.gz
+d295fc93f39bbf0fd937b730a93184899a2eb6c3a6d53f3d857cbe77ef89b98c  bitcoin-0.17.2-i686-pc-linux-gnu.tar.gz
+a783ba20706dbfd5b47fbedf42165fce70fbbc7d78003305d964f6b3da14887f  bitcoin-0.17.2-osx64.tar.gz
+095c6c04f3fe6e9cc15347d15f499564bdc7ce68e3266cc8bb52308bdcada070  bitcoin-0.17.2-osx.dmg
+df085e04b9d03d6d1592146dc50ac0dfcda267519ba4b586d8707ebe6c7d80da  bitcoin-0.17.2.tar.gz
+ffe5d457aaa4b7760ab5653c7deae283aaa381baf1e7c4a33099689c7d766187  bitcoin-0.17.2-win64-setup.exe
+575d99bf7d4dd93088b3515ebcd2c0c5ecaecb07fbd3bd081c0e18eb56658b4d  bitcoin-0.17.2-win64.zip
+943f9362b9f11130177839116f48f809d83478b4c28591d486ee9a7e35179da6  bitcoin-0.17.2-x86_64-linux-gnu.tar.gz
+-----BEGIN PGP SIGNATURE-----
+Version: GnuPG v1.4.11 (GNU/Linux)
+
+iQIcBAEBCAAGBQJd3VEoAAoJEJDIAZ42wulk5cQQAJScPo8adQhjAkad4J7ZSpgy
+ISVPn8zoO45ZB+LsEMsAwcnFzw8SKtGuXqJFuzf/+uwprpcIwiFsSSNpNHevWSA1
+byMUIFWMvFf253eO1mM+ILpkPtHJGgB5iZjBrhlSR7yQrlIy47A47muyiThYnVAv
+HSNEgfhFWGOGJ5uXPggb/alBw9WGLZAP78MKTAutXnNPGlqt28VfuT7gldmNlFj8
+Nz0wj0rwKI5ygLjn1wUsFbJzHPAfjNpk42wY3cQKOyu9af4VgRGQntRvm2TgXyOB
+qnmf2JFRnca28qM/YlrFjjPLaY3s3ZnUyExs4sAnbmO06KtKWm9jZkLwefW30elv
+OdcnmcvliD1wvb7+j5S7Y/N1HLM52feVdt8UNDk65xGBrUIGL5Bf8q3WlrAyz8tC
+6NjglZ4NP2sq/i6kVf7Pe3ELMGOquAAFbs+gvOQjg3jqBh+BJREJu+ofiXR4QbIy
+qALoUqLnhpvMVuwF9JHeozrc5EThw/2r91lnf5w8gxm9VvJGQ7wB+404XlzSWeSf
+q56Ps11U7SMP5QSyDF00wn9Armglg3NgiAKaRf/ziypeyOK2e4sUX4Bf3JcJFix9
++rq2ebHrZLdquDerxFHClTTtmma9hQZrrVzVtbdWCZeb432vW3IsiMJNslTHXrNb
+lzFkhWVssVE4EaiSHR+8
+=IiEa
+-----END PGP SIGNATURE-----

node/sha256/bitcoin-core-0.17.2-SHA256SUMS.asc

@@ -51,7 +51,7 @@ pub use corepc_client::{client_sync::v19::{Client, AddressType}, types::v19 as v
 #[cfg(all(feature = "0_18_1", not(feature = "0_19_1")))]
 pub use corepc_client::{client_sync::v18::{Client, AddressType}, types::v18 as vtype};
 
-#[cfg(all(feature = "0_17_1", not(feature = "0_18_1")))]
+#[cfg(all(feature = "0_17_2", not(feature = "0_18_1")))]
 pub use corepc_client::{client_sync::v17::{Client, AddressType}, types::v17 as vtype};
 
 /// This is meaningless but we need it otherwise we can't get far enough into
@@ -72,6 +72,6 @@ pub use corepc_client::{client_sync::v17::{Client, AddressType}, types::v17 as v
     not(feature = "0_20_2"),
     not(feature = "0_19_1"),
     not(feature = "0_18_1"),
-    not(feature = "0_17_1")
+    not(feature = "0_17_2"),
 ))]
 pub use corepc_client::{client_sync::v28::{Client, AddressType}, types::v28 as vtype};

node/src/client_versions.rs

@@ -16,7 +16,7 @@
     not(feature = "0_20_2"),
     not(feature = "0_19_1"),
     not(feature = "0_18_1"),
-    not(feature = "0_17_1")
+    not(feature = "0_17_2")
 ))]
 compile_error!("enable a feature in order to select the version of Bitcoin Core to use");
 
@@ -66,8 +66,8 @@ pub const VERSION: &str = "0.19.1";
 #[cfg(all(feature = "0_18_1", not(feature = "0_19_1")))]
 pub const VERSION: &str = "0.18.1";
 
-#[cfg(all(feature = "0_17_1", not(feature = "0_18_1")))]
-pub const VERSION: &str = "0.17.1";
+#[cfg(all(feature = "0_17_2", not(feature = "0_18_1")))]
+pub const VERSION: &str = "0.17.2";
 
 /// This is meaningless but we need it otherwise we can't get far enough into
 /// the build process to trigger the `compile_error!` in `./versions.rs`.
@@ -87,6 +87,6 @@ pub const VERSION: &str = "0.17.1";
     not(feature = "0_20_2"),
     not(feature = "0_19_1"),
     not(feature = "0_18_1"),
-    not(feature = "0_17_1")
+    not(feature = "0_17_2")
 ))]
 pub const VERSION: &str = "never-used";