Skip to content

client_sync::Error has unnecessary variants #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tcharding opened this issue Apr 8, 2025 · 0 comments · May be fixed by #127
Open

client_sync::Error has unnecessary variants #119

tcharding opened this issue Apr 8, 2025 · 0 comments · May be fixed by #127

Comments

@tcharding
Copy link
Member

The client_sync::Error was originally copied from bitcoincore-rpc which uses serde during the RPC calls so it has variants related to deserializing rust-bitcoin types. This library only uses stdlib types when doing RPC calls so these variants are unnecessary.
@GideonBature GideonBature linked a pull request Apr 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary error variants GideonBature/corepc
1 participant
@tcharding