Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getaddressinfo "label" field is deprecated #123

Open
justinmoon opened this issue Jul 30, 2020 · 3 comments
Open

getaddressinfo "label" field is deprecated #123

justinmoon opened this issue Jul 30, 2020 · 3 comments

Comments

@justinmoon
Copy link
Contributor

justinmoon commented Jul 30, 2020 •
edited
Loading

Bitcoin Core will remove the field in 0.21.

Should we make this field an Option?
@justinmoon
Copy link
Contributor Author

It already does this! I had outdated version ...

@justinmoon justinmoon reopened this Jul 31, 2020
@justinmoon
Copy link
Contributor Author

Hmm looks like this is still an issue.

Looks like the "embedded" type's label turned into an Option but the top-level type's label field didn't.

@justinmoon justinmoon changed the title getaddressinfo.label is deprecated getaddressinfo "label" field is deprecated Jul 31, 2020
@stevenroose
Copy link
Collaborator

stevenroose commented Aug 1, 2020 •
edited
Loading

If the top level label field is deprecated, it should be an option. Perhaps we should have like a policy of deprecation. It's really hard to keep up with Core RPC changes in a reliable way.

As a policy I think it makes sense to pick a certain number of version (say 2 major versions) and mark anything beyond that as "deprecation" using a #[deprecated(note = "removed since Bitcoin Core v0.18.1")] or something. And only effectively removing support if it becomes technical debt we no longer want to bear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stevenroose @justinmoon