Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue with PublicKey deserialize #23

Open
nkostoulas opened this issue Mar 12, 2019 · 3 comments
Open

issue with PublicKey deserialize #23

nkostoulas opened this issue Mar 12, 2019 · 3 comments

Comments

@nkostoulas
Copy link
Contributor

nkostoulas commented Mar 12, 2019 •
edited
Loading

I've been trying to add a new result struct that required deserialising secp256k1::PublicKey but it seems to fail with "expected a borrowed byte array".

Are you aware of any way around this? I see it's serialised in PubKeyOrAddress but not deserialised anywhere.
@stevenroose
Copy link
Collaborator

Not sure if it implements serde deserialization, but rust-bitcoin now has a util::key::PublicKey type. So we shouldn't be using the secp types directly anymore.

@stevenroose
Copy link
Collaborator

I saw that it doesn't implement serde. Let me PR that.

@nkostoulas
Copy link
Contributor Author

nkostoulas commented Mar 19, 2019 •
edited
Loading

Oh it's related to this rust-bitcoin/rust-secp256k1#73

@stevenroose stevenroose added this to the v0.3.0 milestone Apr 1, 2019
@stevenroose stevenroose mentioned this issue Apr 1, 2019
Closed
@stevenroose stevenroose removed this from the v0.3.0 milestone Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use bitcoin::PublicKey instead of secp256k1 stevenroose/rust-bitcoincore-rpc
2 participants
@stevenroose @nkostoulas