Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV of proc_macro2 is 1.31 #84

Open
thomaseizinger opened this issue Oct 24, 2019 · 1 comment
Open

MSRV of proc_macro2 is 1.31 #84

thomaseizinger opened this issue Oct 24, 2019 · 1 comment

Comments

@thomaseizinger
Copy link
Contributor

Currently, the build against Rust 1.24 fails because proc_macro2 requires Rust 1.31.

The dependency is brought in by serde_derive:

image

If we want to keep supporting Rust 1.24, it seems like the options are:

  • drop serde_derive (and reimplement the serialization manually)
  • pin it to a version that compiles on Rust 1.24 (rust-bitcoin pins it to <1.0.99)

Neither of them seem to be like a great idea:

  • dropping serde_derive means we'd have to write a lot of boilerplate
  • pinning the version limits downstream users in which features of serde_derive they can access

What are your thoughts on supporting Rust 1.24 in this repo @stevenroose ?
Currently, none of the PRs (like #80) can be merged because of the failing build for Rust 1.24.

@thomaseizinger
Copy link
Contributor Author

Ping @stevenroose are there any plans on resolving this? bitcoincore-rpc depending on an outdated version of rust-bitcoin is currently blocking us from updating rust-bitcoin (which we'd really want, esp. with the new-types coming in on the next release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant