Skip to content

skip skeptic #738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

skip skeptic #738

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/mdbook-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,5 +31,5 @@ jobs:
echo "✅ All tests passed!"
else
echo "❌ Some tests failed. Check the logs above for details."
exit 1
echo "⚠️ Tests are not required to pass - continuing workflow."
Copy link
Contributor

@joshka joshka Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious, what the purpose of this job was over just failing the test step.

Looking at the output, you'll still see that the job fails due to the cargo_test step failing.

Is this perhaps a translation from the previous (TravisCI?) workflow or something like that?

Copy link
Contributor Author

@AndyGauge AndyGauge Oct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to get the ci step optional, but it just turns out that I don't have the same permissions that I had before August 9th. I've raised on Zulip but I'm not sure how to maintain the cookbook.

Copy link
Contributor

@joshka joshka Oct 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this repo is setup to not allow merges when CI fails and you're not an admin of this repo?

If you want to turn that off for this step, then:
https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#jobsjob_idstepscontinue-on-error

The step will still run and be marked as failed, but it won't cause the job to fail.

fi
Loading